Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OP#41290] Add ui for delete an link between work-package and file #87

Merged
merged 9 commits into from
Apr 12, 2022
Merged

[OP#41290] Add ui for delete an link between work-package and file #87

merged 9 commits into from
Apr 12, 2022

Conversation

SwikritiT
Copy link
Collaborator

@SwikritiT SwikritiT commented Mar 22, 2022 •
edited
Loading

OP#41290 delete an link between work-package and file
link to wp: https://community.openproject.org/projects/nextcloud-integration/work_packages/41290

Figma link: https://www.figma.com/file/gtLQfPe09X7XugAH8L7dTy/Nextcloud-Integration?node-id=31%3A6923
tested with: opf/openproject#10052

UI looks like

Light theme

light
lightUnlink

Dark theme

dark

darkUnlink

@SwikritiT SwikritiT changed the title Add ui for delete link [OP#41290] Add ui for delete link Mar 24, 2022
@SwikritiT SwikritiT changed the title [OP#41290] Add ui for delete link [OP#41290] Add ui for delete an link between work-package and file Mar 24, 2022
@SwikritiT SwikritiT self-assigned this Mar 24, 2022
@SwikritiT SwikritiT marked this pull request as ready for review March 24, 2022 11:15
individual-it
individual-it requested changes Mar 25, 2022
View reviewed changes
src/views/ProjectsTab.vue Outdated Show resolved Hide resolved
src/views/ProjectsTab.vue Outdated Show resolved Hide resolved
@SwikritiT SwikritiT force-pushed the delete-file-links-UI branch 2 times, most recently from 1e92d60 to d52bafe Compare March 28, 2022 06:57
kiranparajuli589
kiranparajuli589 reviewed Mar 29, 2022
View reviewed changes
src/views/ProjectsTab.vue Outdated Show resolved Hide resolved
src/views/ProjectsTab.vue Outdated Show resolved Hide resolved
tests/jest/views/ProjectsTab.spec.js Outdated Show resolved Hide resolved
tests/jest/views/ProjectsTab.spec.js Outdated Show resolved Hide resolved
@SwikritiT SwikritiT marked this pull request as draft April 1, 2022 08:19
@SwikritiT
Copy link
Collaborator Author

https://www.figma.com/file/gtLQfPe09X7XugAH8L7dTy/Nextcloud-Integration?node-id=886%3A31892#173680750 design has been changed a little bit. So converting this to draft

@individual-it individual-it removed their request for review April 4, 2022 06:37
@SwikritiT SwikritiT force-pushed the delete-file-links-UI branch 2 times, most recently from 7647f14 to 607a679 Compare April 5, 2022 03:21
@SwikritiT SwikritiT marked this pull request as ready for review April 5, 2022 03:41
kiranparajuli589
kiranparajuli589 reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SwikritiT
Add ui for delete link
55313bf 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT
Use nextcloud Action component
3d4fd15 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT
lint fixed
be0462d 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT
update snapshot
acbb10d 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT
Add unit test and update snapshot
f526fcd 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT
Remove uneeded code and minor fix up
302bafb 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT
Add action seperator
96399b3 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT
Refactor unit tests
116d08d 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@SwikritiT
Change the design of UI
f1ba2ec 
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@github-actions
Copy link

JS Code Coverage

Coverage after merging delete-file-links-UI into master will be
56.63%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   utils.js8.33%0%0%14.29%3–9, 9
src/components
   AdminSettings.vue40.91%100%16.67%50%73–75, 79, 86–87, 89, 92
   OAuthConnectButton.vue93.10%100%85.71%95.45%45
   PersonalSettings.vue37.14%30%33.33%42.11%100–101, 101, 101, 104–105, 105, 105, 108–109, 109, 109, 112, 115–116, 118–119, 119–121, 121, 121, 121–122, 127–128, 128, 128, 133, 139, 87–90, 96–97
src/components/settings
   SettingsTitle.vue0%100%0%0%14
src/components/tab
   EmptyContent.vue100%100%100%100%
   SearchInput.vue89.80%80%93.75%91.04%109, 109, 109–110, 112, 157, 71, 93–94
   WorkPackage.vue100%100%100%100%
src/utils
   workpackageHelper.js95.12%95.24%100%94.12%11, 19
src/views
   Dashboard.vue0%0%0%0%100–101, 101–102, 104, 107, 112, 112, 112–113, 115, 121, 125–126, 134, 137, 141–143, 145, 148–149, 152–153, 153–154, 158–159, 159–160, 162, 164–165, 165, 165, 165, 165–167, 167, 167, 167, 167–169, 172, 177, 177, 177, 179–180, 180, 180–181, 183, 183–185, 189, 193, 196, 196, 196, 199, 199, 199, 204, 207, 207, 207, 214, 217, 217, 217, 222, 222, 222, 227, 227, 227, 23, 232, 235, 238, 24, 241, 241, 241, 244, 244, 244, 247, 25, 250, 253, 26–31, 48, 55, 55, 62, 65–66, 78–79, 79, 79, 82, 85, 85, 85–87, 87, 87–89, 89–90, 92, 95, 95, 95–97, 97, 97–99, 99, 99
   ProjectsTab.vue91.23%100%71.43%91.43%79, 98–99

@github-actions
Copy link

PHP Code Coverage

Coverage after merging delete-file-links-UI into master will be
51.10%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php0%100%0%0%49, 51–52, 54–55, 59–60, 63, 70, 74–77, 79–84, 95, 99
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php67.47%100%60%67.95%101–102, 104, 115–116, 118, 213–216, 218–219, 222, 81–82, 84, 86–88, 90–95
   OpenProjectAPIController.php77.78%100%75%78.13%164, 181–182, 185, 188, 193, 195–200, 202, 90
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%106–107, 109–113, 61–64, 71, 78, 85, 92, 99
lib/Exception
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectResponseException.php0%100%0%0%16
lib/Listener
   LoadSidebarScript.php0%100%0%0%59–61, 65–66, 68, 70, 72–74, 76, 78–82
lib/Notification
   Notifier.php0%100%0%0%100–104, 109–110, 112, 114, 47–50, 60, 69, 80, 82, 85, 87–92, 95, 97
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123–125, 127–128, 130–132, 135–136, 138–139, 143–144, 146–148, 154–155, 157, 166, 174–180, 189–194, 203, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   OpenProjectAPIService.php70.71%100%72.22%70.59%106–107, 116–124, 126–135, 137–138, 141–142, 158–162, 172–173, 175–179, 181, 190–194, 373, 390–391, 393, 408–411, 413, 479–480, 487, 490–493, 495, 501, 505–507, 650
lib/Settings
   Admin.php0%100%0%0%25–26, 33–35, 37, 42–43, 47, 51
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php84%100%50%90.48%75, 79
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

@SwikritiT SwikritiT mentioned this pull request Apr 12, 2022
Merged
@individual-it individual-it merged commit b66dc63 into master Apr 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the delete-file-links-UI branch April 12, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@individual-it individual-it individual-it approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

@SwikritiT SwikritiT

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@SwikritiT @individual-it @kiranparajuli589