Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/41135 include all subprojects #10413

Merged
merged 37 commits into from
Apr 7, 2022
Merged

Feature/41135 include all subprojects #10413

merged 37 commits into from
Apr 7, 2022

Conversation

b12f
Copy link
Contributor

@b12f b12f commented Mar 31, 2022

Depends on #10368

oliverguenther and others added 30 commits March 23, 2022 15:24
@oliverguenther
Add new query attribute include_subprojects
1c3aec7
@oliverguenther
Set include_subprojects in factories
83ea4c3
@oliverguenther
Replace create_query helper with default endpoint
fb35487
@oliverguenther
Adapt spec to new query create service
381cec2
@oliverguenther
Add spec for changed subproject behavior
c0aef66
@oliverguenther
Extend project filter with replaced values and add spec
09317d1
@oliverguenther
Fix spec trying to save default query
8a37e54
@oliverguenther
Fix ordered_work_packages now that we're base service compatible
5b8fd5e
Basic frontend for include all subprojects
5e69e26
Fix disabled state, update button colors
903ec8c
@oliverguenther
Add new query attribute include_subprojects
718c2a0
@oliverguenther
Set include_subprojects in factories
8becbbc
@oliverguenther
Replace create_query helper with default endpoint
11818fd
@oliverguenther
Adapt spec to new query create service
6d1cfde
@oliverguenther
Add spec for changed subproject behavior
0e12020
@oliverguenther
Extend project filter with replaced values and add spec
13c1577
@oliverguenther
Add a ParserStruct overriding Enumerable#group_by
72d773a
@oliverguenther
Fix ordered_work_packages now that we're base service compatible
d244c66
Add tooltip
3420164
Add tooltips to include projects
2345c43
Add is parameter to query props for query space
0baa0c8
Merge branch 'feature/include-subprojects-attribute' into feature/411…
488dd36 
…35-include-all-subprojects
Fix specs, add i18n strings
c1ba924
@oliverguenther
Correctly parse and update the query with includeSubprojects
b9a192b
FIx most spec
665396a
Fix badge count for team planner spec, fix duplicated where def in pr…
d5219e6 
…oject filter
Only load project list if opening drop modal
5dcd7be
@oliverguenther
Expect that sub_sub_bug is also present
c92dc4e
I18nify the strings
a21dabc
Fix typo
6d0f3d0
@b12f b12f marked this pull request as ready for review April 4, 2022 15:17
@oliverguenther oliverguenther self-requested a review April 5, 2022 14:45
oliverguenther
oliverguenther approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 There are still a few failing tests though

@b12f b12f merged commit b7f732d into dev Apr 7, 2022
@b12f b12f deleted the feature/41135-include-all-subprojects branch April 7, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b12f @oliverguenther