Update time_entry.rb #12651
Closed
Update time_entry.rb #12651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update comments length, 255 is too small
|
Hi @zencmp, I think we could just remove that constraint but setting to a higher value is also okay for now. One test is now failing which tested the restriction. Could you adapt that please? ./modules/costs/spec/contracts/time_entries/update_contract_spec.rb[1:1:14:1] # TimeEntries::UpdateContract behaves like time entry contract when comment is longer than 255 is invalid Best |
oliverguenther
approved these changes
May 22, 2023
|
Closing in favor of https://github.com/opf/openproject/pull/12654/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating comments length, 255 is too small for work description. DB doesn't have constraints for this field