-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework membership on global entities and implement ProjectQueryRole #15644
Conversation
aabe027
to
4eadaa6
Compare
190e7a6
to
9b9e91f
Compare
2706c65
to
c8558a7
Compare
d907634
to
4da73eb
Compare
edit_project_query | ||
] | ||
) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unsolved question on my end. Doing this will have lead to the roles being written to the database. And we definitely want to have that for installations that just do a migration from say 14.0 to the current one. But it will do the same for new instances. And that renders the seeding of the roles worthless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had the same discussion when we introduced the roles for WorkPackages. First we planned to do it with seeds only, but later we still added them via a migration as well.
As we have a unique identfier with the builtin column being filled, the migration and the seeds would be idempotent as they would lead to the same result.
I have no problem removing them from the seeds, I just think it's more complete to have them in both.
dfc0675
to
a6c3e2e
Compare
a6c3e2e
to
dc7002c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @klaustopher !👍 I just left one question.
entity present
+project nil
ProjectQueryRole
and the permissionsallowed_to
scope forProjectQuery
visible
and addeditable
method toProjectQuery
Implements https://community.openproject.org/work_packages/55160
Implements https://community.openproject.org/work_packages/55161