Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shared_let and explicitly set user for public_query #15674

Merged
merged 1 commit into from
May 27, 2024
Merged

Use shared_let and explicitly set user for public_query #15674

merged 1 commit into from
May 27, 2024

Conversation

klaustopher
Copy link
Contributor

@klaustopher klaustopher commented May 27, 2024 •
edited
Loading

Follow up to #15609

@klaustopher klaustopher requested a review from toy May 27, 2024 12:27
toy
toy approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@toy toy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please mention that it is a follow up of other PR

@klaustopher klaustopher merged commit f336189 into dev May 27, 2024
9 checks passed
@klaustopher klaustopher deleted the simpler-tests-queries branch May 27, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toy toy toy approved these changes

Assignees
No one assigned
Labels
needs review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klaustopher @toy