Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOS Script? #2

Open
JamoCA opened this issue Jan 26, 2019 · 2 comments
Open

DOS Script? #2

JamoCA opened this issue Jan 26, 2019 · 2 comments

Comments

@JamoCA
Copy link

JamoCA commented Jan 26, 2019

If there's a problem with the icecast stream (or playlist URLs), this script will repeatedly request the playlist URLs non-stop. Dpeending on the endpoint, it may be seen as a DOS attack. If the remote M3U file uses local paths or single filename, the local path of the webserver will be requested rather than the remote icecast server.

@opi
Copy link
Owner

opi commented Jan 26, 2019

thanks for reporting this issue.

Do you suggest anything to prevent this behavior ?

@JamoCA
Copy link
Author

JamoCA commented Jan 28, 2019

Track the media host/path and enfforce some sort of throttling and/or debouncing. I understand that you want it to retry immediately if a connection is dropped, but if it's not coming back up soon or is overwelmed, performing repeated requests aren't going to to help.

Maybe perform an immediate check at the same host/pasth. If no response, don't try that host/path again for 5 seconds. If no response during next check, set timeout to to 10 seconds. If no response, set the timeout out to 30 seconds (or longer) or flag is as a non-responsive endpoint and skip it in the future (or try again in 5 minutes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants