Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: need go files for package #141

Merged
merged 1 commit into from
Sep 29, 2022
Merged

revert: need go files for package #141

merged 1 commit into from
Sep 29, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Sep 29, 2022

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb
revert: need go files for package
57caedb 
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
mestery
mestery approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@mestery mestery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAS!

@glimchb glimchb mentioned this pull request Sep 29, 2022
Open
@glimchb
Copy link
Member Author

glimchb commented Sep 29, 2022

this is reverting #139 due to this new error

$ docker run --rm -it -v `pwd`:/app -w /app golang:alpine go get github.com/opiproject/opi-api/storage/proto

go: downloading github.com/opiproject/opi-api v0.0.0-20220929153221-95b2b4b0105f
go: module github.com/opiproject/opi-api@upgrade found (v0.0.0-20220929153221-95b2b4b0105f), but does not contain package github.com/opiproject/opi-api/storage/proto

opened issue #142 to track this

@glimchb glimchb merged commit e82b272 into opiproject:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mestery mestery mestery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glimchb @mestery