Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage][front-end] Rename crypto_key_id to volume_id #182

Merged
merged 2 commits into from
Nov 2, 2022
Merged

[storage][front-end] Rename crypto_key_id to volume_id #182

merged 2 commits into from
Nov 2, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Nov 2, 2022

  • [storage][front-end] Rename crypto_key_id to volume_id
  • [storage] auto-generate protos

@glimchb glimchb requested a review from a team as a code owner November 2, 2022 00:54
@glimchb glimchb self-assigned this Nov 2, 2022
@glimchb glimchb added Storage APIs or code related to storage area Merge Candidate in the open merge window, next candidate for merge labels Nov 2, 2022
@glimchb
[storage][front-end] Rename crypto_key_id to volume_id
c20f4f9 
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb
[storage] auto-generate protos
f675771 
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Nov 2, 2022
@glimchb
fix code after API changes
de11dee 
see opiproject/opi-api#182

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb mentioned this pull request Nov 2, 2022
Merged
jainvipin
jainvipin approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@jainvipin jainvipin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jainvipin
Copy link
Contributor

jainvipin commented Nov 2, 2022 •
edited
Loading

minor: if you want to consider: if you want to rename volume_services_id that would reflect it better i.e. it represent services performed on this volume in the middle/backend.

@glimchb glimchb mentioned this pull request Nov 2, 2022
Open
@glimchb
Copy link
Member Author

glimchb commented Nov 2, 2022

Poll in slack + approvals here, going to merge this change now

@glimchb glimchb merged commit 805c63e into opiproject:main Nov 2, 2022
@glimchb glimchb deleted the crypto branch November 2, 2022 19:57
glimchb added a commit to glimchb/opi-spdk-bridge that referenced this pull request Nov 2, 2022
@glimchb
fix code after API changes
103078f 
see opiproject/opi-api#182

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to opiproject/opi-spdk-bridge that referenced this pull request Nov 2, 2022
@glimchb
fix code after API changes
a3fcf1c 
see opiproject/opi-api#182

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainvipin jainvipin jainvipin approved these changes

@benlwalker benlwalker benlwalker approved these changes

@mkalderon mkalderon mkalderon approved these changes

@llabordehpe llabordehpe llabordehpe approved these changes

@orendu orendu Awaiting requested review from orendu

@PWAlessi PWAlessi Awaiting requested review from PWAlessi

Assignees

@glimchb glimchb

Labels
Merge Candidate in the open merge window, next candidate for merge Storage APIs or code related to storage area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glimchb @jainvipin @benlwalker @mkalderon @llabordehpe