[storage] Add Crypto middle end volume #208
Conversation
glimchb
requested review from
a team,
benlwalker,
jainvipin,
llabordehpe,
mkalderon and
orendu
|
Should the Crypto functionality be included in the middle end protobuf or should there be a separate common crypto capability that can be tied to the function (Storage, Security, Networking, etc.) that would create, delete, update, ... the capability? Perhaps we can iterate on that aspect of the common functionality. |
d@re (data at rest encryption) is only applicable for storage we can definitely iterate on this common once we have another example that uses the same, we can easily move it around to a common place |
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
|
| service MiddleendService { | ||
| rpc CreateCrypto (CreateCryptoRequest) returns (Crypto) { | ||
| option (google.api.http) = { | ||
| post: "/v1/volumes" |
There was a problem hiding this comment.
the flat API structure is evident here v1/volumes is very generic, if we preceed it with v1/middleend/volumes that would decouple it from the backend volumes and overlap.
| common.v1.ObjectKey volume_id = 2; | ||
|
|
||
| // Key to be used for encryption | ||
| bytes key = 3; |
There was a problem hiding this comment.
Is it a shared secret or a private key?
There was a problem hiding this comment.
do we need to provide secret for initial vector or do we believe use of IV is perhaps a stale thing?
There was a problem hiding this comment.
no idea, this is just first draft, let's discuss
|
|
||
| message CryptoStatsResponse { | ||
| common.v1.ObjectKey crypto_id = 1; | ||
| string stats = 2; |
There was a problem hiding this comment.
same comment about stats as in other PRs
| } | ||
|
|
||
| message CreateCryptoRequest { | ||
| Crypto volume = 1; |
There was a problem hiding this comment.
minor, why do we call the field volume it should be called crypto? e.g. what if we have other service applied on the volume, would that also be called volume in the create/update requests?
Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com