Marvell rpc api update #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glimchb
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
LGTM, thanks!
please fix CI errors
Error: ./frontend.go:181:3: unknown field 'IsPf' in struct literal of type MrvlNvmSubsysCreateCtrlrParams
Error: ./frontend.go:182:3: unknown field 'InstanceID' in struct literal of type MrvlNvmSubsysCreateCtrlrParams
Error: ./frontend.go:249:3: unknown field 'IsPf' in struct literal of type MrvlNvmSubsysCreateCtrlrParams
Error: ./frontend.go:250:3: unknown field 'InstanceID' in struct literal of type MrvlNvmSubsysCreateCtrlrParams
and we good to merge
Updated the flag names to mrvl_rpc_sock and mrvl_port. Signed-off-by: Vaibhav Jain <vaibhavj@marvell.com> Signed-off-by: Michal Kalderon <mkalderon@marvell.com>
1. Added explicit pf_id , vf_id argument inplace of is_pf 2. Replaced instance_id argument with ctrl_id 3. Added sqes and cqes argument Signed-off-by: Vaibhav Jain <vaibhavj@marvell.com> Signed-off-by: Michal Kalderon <mkalderon@marvell.com>
VaibhavJMarvell
force-pushed
the
main
branch
from
78c4d94
to
b326f1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed redefinition error for flags rpc_sock and port. Updated the flag names to mrvl_rpc_sock and mrvl_port.
Updated JSON arguments as per Marvell api update.