firmware: upgrade_needs_reboot flag is overloaded

[fichtner]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

When upgrade_needs_reboot is propagated to the GUI nowadays a major update will force the flag as well. But when there are minor updates pending that don't require a reboot the system will perform the minor update (as it should) but claim it requires a reboot which it does not.

To Reproduce

Visible on development track with sticky beta upgrade possibility.

Expected behavior

Separate reboot flags. The larger issue is that upgrade_needs_reboot is actually for updates only but used in code already so renaming it and splitting the flags in two is difficult.

Describe alternatives you considered

Back out 19a927c and let it be implied that set upgrades always require a reboot.

Screenshots

N/A

Relevant log files

N/A

Additional context

N/A

Environment

22.1.b

[fichtner]

New flag status_reboot now exists with the correct reboot status for the advertised status.