OpenVPN wizard server cert check #3634
Merged
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the issue described in opnsense#3617
AdSchellevis
reviewed
Aug 7, 2019
AdSchellevis
reviewed
Aug 7, 2019
|
@johnaheadley Looks good apart from some minor psr remarks. I agree we can better filter the options in the wizard. The wizard itself isn't very great (code is quite messy), but is difficult to phase out now, it's always good to smoothen the edges a bit :) Thanks! |
|
@johnaheadley thanks! |
fichtner
pushed a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue I described in #3617.
In the case that both server and non-server certs are present, I chose to have the wizard just filter out non-server certificates from the Server Certificate Selection dropdown.
This is in contrast to the vpn_openvpn_server.php which shows the user all certificates, let's you select a non-server certificate, but then displays an error when trying to save (screenshot of error in issue report.) We can echo this behavior if you think this is a better UX.