Fix scaling of small images, fix typos, clarify IPsec s2s #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Nov 7, 2018
source/manual/how-tos/ips-feodo.rst
Outdated
| @@ -70,7 +70,7 @@ To do so: select Enabled after each one. | |||
|
|
|||
| To download the rule sets press **Download & Update Rules**. | |||
|
|
|||
| .. image:: images/downloadbtn.png | |||
| .. scale:: images/downloadbtn.png | |||
There was a problem hiding this comment.
image -> scale, not width -> scale like the other two?
also :scale: was changed to :width: in earlier commits because it squashes larger images
There was a problem hiding this comment.
hehe, ok. maybe there is a more portable setting than cranking every :scale: and :width: to 100% ?
There was a problem hiding this comment.
That could be the case, indeed. I was following @jschellevis ' instructions here.
For small images that don't need resizing, we might be able to leave out both instructions.
|
From the Sphinx manual: In other words: it can be left out. I discussed this with @jschellevis and he agreed on doing so. |
|
nice, thanks |
|
@MichaelDeciso thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This manual leaves IPsec Road Warrior alone, since there is already a PR open for that.
It does touch IPsec S2S, which is not covered by #72.