-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGINX: configurable listen addresses #2574
Comments
it ate my formatting, so: proposed solution:
|
Might even be possible to do #1218 at the same time. |
See Pull Request #2578 . |
fichtner
pushed a commit
that referenced
this issue
Nov 22, 2021
…, #2574 (#2578) - Changed listen_http_port, listen_https_port, listen_port to listen_http_address, listen_https_address, listen_address (issue #973, #2574) - Migrated the old listen_X_port to the new listen_X_address - Data Model ver 1.20.0 -> 1.21.0 - implemented default_server directive for non-tls listeners (issue #1218) - amended Help Message - added defaults for http server listen addresses - added changelog - fixed setup.php certificate setup - fixed inexplicable missing Reconfigureaction in ServiceController - fixed version numbers - removed reconfigureaction in ServiceController again, because it was due to a code cleanup by fichtner and has to be fixed on a higher level - added NgxUniqueDefaultServerConstraint which makes sure that default_servers do not conflict - added i18n for the error message - fixed some formatting issues - added type hints
AdSchellevis
pushed a commit
that referenced
this issue
Feb 2, 2022
…, #2574 (#2578) - Changed listen_http_port, listen_https_port, listen_port to listen_http_address, listen_https_address, listen_address (issue #973, #2574) - Migrated the old listen_X_port to the new listen_X_address - Data Model ver 1.20.0 -> 1.21.0 - implemented default_server directive for non-tls listeners (issue #1218) - amended Help Message - added defaults for http server listen addresses - added changelog - fixed setup.php certificate setup - fixed inexplicable missing Reconfigureaction in ServiceController - fixed version numbers - removed reconfigureaction in ServiceController again, because it was due to a code cleanup by fichtner and has to be fixed on a higher level - added NgxUniqueDefaultServerConstraint which makes sure that default_servers do not conflict - added i18n for the error message - fixed some formatting issues - added type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[X] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues and I'm convinced that mine is new.
[X] When the request is meant for an existing plugin, I've added its name to the title.
Is your feature request related to a problem? Please describe.
Referencing issue #973
We have clients that have multiple public IPs so that they can have each public IP serve a different purpose. If I just configure a nginx at port 443, I destroy that advantage, and make every public IP the same, so I might just have a single one.
Describe the solution you'd like
So, I'm willing to do the work, which should not be much, the plan being:
So, in order not to waste everyones time, if I create such a pull request and it passes code checks, would it be accepted, or is that functionality just not wanted, as it seems to be according to issue #973?
Describe alternatives you've considered
Using HAProxy, since nginx, while preferred, is useless to me this way.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: