Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os-nginx: Add option for upstream keepalive #3162

Closed
3 tasks done
sigurdvaa opened this issue Oct 16, 2022 · 2 comments · May be fixed by #3678
Closed
3 tasks done

os-nginx: Add option for upstream keepalive #3162

sigurdvaa opened this issue Oct 16, 2022 · 2 comments · May be fixed by #3678
Labels
help wanted Contributor missing

Comments

@sigurdvaa
Copy link

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.
For performance tuning I would like to be able to enable keepalive for upstream connections.

Describe the solution you'd like
Two new options in Upstream:

  • Keepalive: how many connections to keep alive upstream (0 or empty for disabled)
  • Keepalive Timeout: how long to wait for closing an idle upstream connection

Describe alternatives you've considered
Not really any alternatives, as the keepalive directive must be set in the upstream context, which will be overwritten when pressing Apply in the WebUI.

Additional context
This will require two new directives in the upstream context and two in the location context when upstream keepalive is enabled:
upstream

  • keepalive [int];
  • keepalive_timeout [int];

location

  • proxy_http_version 1.1;
  • proxy_set_header Connection "";
kulikov-a added a commit to kulikov-a/plugins that referenced this issue Apr 2, 2023
kulikov-a added a commit to kulikov-a/plugins that referenced this issue Apr 3, 2023
@OPNsense-bot
Copy link

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository,
please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.

@OPNsense-bot OPNsense-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2023
@OPNsense-bot OPNsense-bot added the help wanted Contributor missing label Apr 14, 2023
@1249993110
Copy link

I also need proxy_http_version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributor missing
Development

Successfully merging a pull request may close this issue.

3 participants