www/nginx: 1.33 #3678

kulikov-a · 2023-11-18T19:28:19Z

Hi!
a few more suggestions )

Add the resolver directive support (closes NGINX resolver config missing #3664)
Add config preview/test/copy to GUI
Add gzip disabling support (closes [nginx] Add option to disable HTTP compression #3245)
Move bot UA settings to GUI (closes Nginx reverse proxy filters DAVx⁵ Android app #2175)
Add auto-ban logging support (for better understanding/tuning/debugging)
Add Upstream keepalive support (https://www.nginx.com/blog/avoiding-top-10-nginx-configuration-mistakes/#no-keepalives) (closes os-nginx: Add option for upstream keepalive #3162)
Convert epoch time to readable format on Services: Nginx: Banned page
Cosmetic: add table header borders on Traffic Statistic page for better reading
upd:
Add Stream proxy_connect_timeout and proxy_timeout directives support (closes www/nginx: Support proxy_timeout 0; for stream configurations #3538)

Thanks!

fabianfrz

looks almost good

www/nginx/src/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/httpserver.xml

www/nginx/src/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/location.xml

www/nginx/src/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/resolver.xml

www/nginx/src/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/settings.xml

www/nginx/src/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/resolver.xml

www/nginx/src/opnsense/mvc/app/views/OPNsense/Nginx/ban.volt

Co-Authored-By: Fabian Franz BSc <fabianfrz@users.noreply.github.com>

kulikov-a · 2023-12-15T13:41:21Z

@fabianfrz i removed .filter-option css rule (introduced in 1.32) to reflect core selectpicker update.

fabianfrz

reviewed again - looks already good - a few minor things.

www/nginx/src/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/location.xml

www/nginx/src/opnsense/mvc/app/controllers/OPNsense/Nginx/forms/resolver.xml

www/nginx/src/opnsense/mvc/app/views/OPNsense/Nginx/index.volt

Co-Authored-By: Fabian Franz BSc <fabianfrz@users.noreply.github.com>

kulikov-a · 2023-12-23T07:06:13Z

@fabianfrz Thanks for the review! I'll try to take your suggestions asap.
Sorry, I didn’t understand one thing: what do you mean by the need for translation in dialogues?
upd. or you mean to translate '{{ lang._('Ok') }}' ? 😃 (I'll proceed from this and update everything tomorrow)

Co-authored-by: Fabian Franz BSc <fabianfrz@users.noreply.github.com>

fabianfrz · 2023-12-23T23:12:24Z

@kulikov-a yes, the label, the rest looks translated.

Co-Authored-By: Fabian Franz BSc <fabianfrz@users.noreply.github.com>

@fabianfrz

-don't use global vars unnecessarily -move css to separate file -don't touch DOM for clipboard copy. use stored value -don't use <pre> if violating standard -add Button label translation -check if clipboard write supported before link show() -use text() instead of html() if possible -change 'DOM ready' handler syntax thnx @fabianfrz

…to ngx_1.33_pr

kulikov-a · 2023-12-24T08:43:44Z

@fabianfrz can you look one more time please )
hope I fixed everything.
I chose the first variant of DOM-ready handler because I didn’t find such syntax in core code and I would like to follow the core style (I'll be happy to switch to ES6 as soon as I see this in core)
same with the buttons - imho they are now where the user expects to see them, given the style of other pages.
XSS possibility discussion: #3678 (comment)
thanks!

use lodash _.unescape to safely decode string without DOM manipulations

fabianfrz · 2023-12-27T00:42:00Z

@kulikov-a regarding ES6: The core was longer supporting IE than my plugins, because they never did (the nginx plugin was on ES6 since day one). So the core was always slower in adopting the new JavaScript syntax. Nowadays you can use ES6 features in core as well since IE is dead.

kulikov-a · 2023-12-27T08:29:30Z

@fabianfrz Thanks!
I'll be happy to try using ES6 even for DOM-ready event on next PRs.
Just trying to follow the product code style (waiting for such a notation to appear in the core or permission from @fichtner and @AdSchellevis)

kulikov-a added 10 commits November 17, 2023 22:18

add resolver directive support

4e65002

add GUI config preview

c816881

gzip disabling support

cec1ec7

move bots UA to GUI

72bd861

Add auto-ban log

78d027e

ban.volt: show readable time in grid

c548a47

vts.css: add tables headers borders

4251e74

Add Upstream keepalives

8b2a939

constraint fix

6bb0b4b

ver bump

92a5344

kulikov-a mentioned this pull request Nov 19, 2023

www/nginx: Support proxy_timeout 0; for stream configurations #3538

Closed

3 tasks

fichtner self-assigned this Nov 20, 2023

fichtner requested review from fichtner, 8191 and fabianfrz and removed request for fichtner November 20, 2023 10:28

Add Stream proxy_connect_timeout and proxy_timeout support

1b652ee

fabianfrz suggested changes Nov 22, 2023

View reviewed changes

fabianfrz reviewed Nov 22, 2023

View reviewed changes

www/nginx/src/opnsense/mvc/app/views/OPNsense/Nginx/ban.volt Outdated Show resolved Hide resolved

maintainer's suggestions

155cd42

Co-Authored-By: Fabian Franz BSc <fabianfrz@users.noreply.github.com>

kulikov-a force-pushed the ngx_1.33_pr branch from 967dc64 to 155cd42 Compare November 23, 2023 05:26

kulikov-a added 2 commits November 23, 2023 08:49

Keepalive vs sockets additional help text

9ae60b9

no moment.js needed

b904e9c

kulikov-a force-pushed the ngx_1.33_pr branch from b573efa to b904e9c Compare November 23, 2023 06:08

kulikov-a requested a review from fabianfrz November 23, 2023 14:24

reflect core selectpicker update

7b433f4

fabianfrz suggested changes Dec 22, 2023

View reviewed changes

maintainer's suggestions

0e35803

Co-Authored-By: Fabian Franz BSc <fabianfrz@users.noreply.github.com>

kulikov-a force-pushed the ngx_1.33_pr branch from a7feb84 to 0e35803 Compare December 23, 2023 06:04

kulikov-a marked this pull request as draft December 23, 2023 06:04

Update www/nginx/src/opnsense/mvc/app/views/OPNsense/Nginx/index.volt

b46e579

Co-authored-by: Fabian Franz BSc <fabianfrz@users.noreply.github.com>

kulikov-a and others added 3 commits December 24, 2023 09:16

maintainer's suggestions

16f441b

Co-Authored-By: Fabian Franz BSc <fabianfrz@users.noreply.github.com>

Merge branch 'ngx_1.33_pr' of https://github.com/kulikov-a/plugins in…

9e7e7f4

…to ngx_1.33_pr

kulikov-a marked this pull request as ready for review December 24, 2023 08:43

kulikov-a requested a review from fabianfrz December 24, 2023 08:43

safety first

e40a6fb

use lodash _.unescape to safely decode string without DOM manipulations

kulikov-a force-pushed the ngx_1.33_pr branch from b6f124d to e40a6fb Compare December 25, 2023 15:21

fabianfrz approved these changes Dec 27, 2023

View reviewed changes

kulikov-a mentioned this pull request Feb 19, 2024

Nginx not using TLS 1.2 despite it being in the config #3825

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

www/nginx: 1.33 #3678

www/nginx: 1.33 #3678

kulikov-a commented Nov 18, 2023 •

edited

fabianfrz left a comment

kulikov-a commented Dec 15, 2023 •

edited

fabianfrz left a comment

kulikov-a commented Dec 23, 2023 •

edited

fabianfrz commented Dec 23, 2023

kulikov-a commented Dec 24, 2023

fabianfrz commented Dec 27, 2023

kulikov-a commented Dec 27, 2023

www/nginx: 1.33 #3678

Are you sure you want to change the base?

www/nginx: 1.33 #3678

Conversation

kulikov-a commented Nov 18, 2023 • edited

fabianfrz left a comment

Choose a reason for hiding this comment

kulikov-a commented Dec 15, 2023 • edited

fabianfrz left a comment

Choose a reason for hiding this comment

kulikov-a commented Dec 23, 2023 • edited

fabianfrz commented Dec 23, 2023

kulikov-a commented Dec 24, 2023

fabianfrz commented Dec 27, 2023

kulikov-a commented Dec 27, 2023

kulikov-a commented Nov 18, 2023 •

edited

kulikov-a commented Dec 15, 2023 •

edited

kulikov-a commented Dec 23, 2023 •

edited