-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRR: OSPF ipv6 influence interface cost via carp #2929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add event handler for ospf6 carp demotion including required interface fields (carp_depend_on and cost_demoted). while here polish some small usability issues, knowing: o Interface networktype and interfacename should be single dropdown boxes o diagnostics / bgp - fix search in grid, should only use a formatter for presentation purposes.
Bring HA features on par with OSPF, adds: o carp_frr_ospf6 rc.carp_service_status.d event handler o add "CARP demote" to model, form and template
o bugfix previous, missing IFS= (internal field seperator)
o missing ospf6d in log event handler
mimugmail
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thx! As I said I can't test in a production network with a HA pair :)
@mimugmail no problem, thanks for looking at it! |
agh1467
pushed a commit
to agh1467/plugins
that referenced
this pull request
Jun 11, 2022
add event handler for ospf6 carp demotion including required interface fields (carp_depend_on and cost_demoted). while here polish some small usability issues, knowing: o Interface networktype and interfacename should be single dropdown boxes o diagnostics / bgp - fix search in grid, should only use a formatter for presentation purposes. o carp_frr_ospf6 rc.carp_service_status.d event handler o add "CARP demote" to model, form and template o bugfix previous, missing IFS= (internal field seperator) o missing ospf6d in log event handler
agh1467
pushed a commit
to agh1467/plugins
that referenced
this pull request
Jun 11, 2022
add event handler for ospf6 carp demotion including required interface fields (carp_depend_on and cost_demoted). while here polish some small usability issues, knowing: o Interface networktype and interfacename should be single dropdown boxes o diagnostics / bgp - fix search in grid, should only use a formatter for presentation purposes. o carp_frr_ospf6 rc.carp_service_status.d event handler o add "CARP demote" to model, form and template o bugfix previous, missing IFS= (internal field seperator) o missing ospf6d in log event handler
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2923
Add event handler for ospf6 carp demotion including required interface fields (carp_depend_on and cost_demoted) and implement "CARP demote" for IPv6 as well to bring HA features on par with OSPF.
While here polish some small usability issues, knowing:
o Interface networktype and interfacename should be single dropdown boxes
o diagnostics / bgp - fix search in grid, should only use a formatter for presentation purposes.