Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRR: OSPF ipv6 influence interface cost via carp #2929

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

AdSchellevis
Copy link
Member

Implements #2923

Add event handler for ospf6 carp demotion including required interface fields (carp_depend_on and cost_demoted) and implement "CARP demote" for IPv6 as well to bring HA features on par with OSPF.

While here polish some small usability issues, knowing:

o Interface networktype and interfacename should be single dropdown boxes
o diagnostics / bgp - fix search in grid, should only use a formatter for presentation purposes.

add event handler for ospf6 carp demotion including required interface fields (carp_depend_on and cost_demoted).
while here polish some small usability issues, knowing:

o Interface networktype and interfacename should be single dropdown boxes
o diagnostics / bgp - fix search in grid, should only use a formatter for presentation purposes.
Bring HA features on par with OSPF, adds:

o carp_frr_ospf6 rc.carp_service_status.d event handler
o add "CARP demote" to model, form and template
@AdSchellevis AdSchellevis added the feature Adding new functionality label Apr 6, 2022
@AdSchellevis AdSchellevis self-assigned this Apr 6, 2022
AdSchellevis added a commit to opnsense/docs that referenced this pull request Apr 6, 2022
o bugfix previous, missing IFS= (internal field seperator)
o missing ospf6d in log event handler
Copy link
Member

@mimugmail mimugmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx! As I said I can't test in a production network with a HA pair :)

@AdSchellevis
Copy link
Member Author

@mimugmail no problem, thanks for looking at it!

@AdSchellevis AdSchellevis merged commit 8d45144 into master Apr 21, 2022
agh1467 pushed a commit to agh1467/plugins that referenced this pull request Jun 11, 2022
add event handler for ospf6 carp demotion including required interface fields (carp_depend_on and cost_demoted).
while here polish some small usability issues, knowing:

o Interface networktype and interfacename should be single dropdown boxes
o diagnostics / bgp - fix search in grid, should only use a formatter for presentation purposes.
o carp_frr_ospf6 rc.carp_service_status.d event handler
o add "CARP demote" to model, form and template
o bugfix previous, missing IFS= (internal field seperator)
o missing ospf6d in log event handler
agh1467 pushed a commit to agh1467/plugins that referenced this pull request Jun 11, 2022
add event handler for ospf6 carp demotion including required interface fields (carp_depend_on and cost_demoted).
while here polish some small usability issues, knowing:

o Interface networktype and interfacename should be single dropdown boxes
o diagnostics / bgp - fix search in grid, should only use a formatter for presentation purposes.
o carp_frr_ospf6 rc.carp_service_status.d event handler
o add "CARP demote" to model, form and template
o bugfix previous, missing IFS= (internal field seperator)
o missing ospf6d in log event handler
@AdSchellevis AdSchellevis deleted the FRR_ospf6_carp_2923 branch July 8, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new functionality
Development

Successfully merging this pull request may close these issues.

None yet

2 participants