WOL widget rewrite for new dashboard #4192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Aug 22, 2024
fichtner
reviewed
Aug 22, 2024
fichtner
reviewed
Aug 22, 2024
fichtner
reviewed
Aug 22, 2024
|
@m3e-g thanks, taking a look at the JS code tomorrow |
Co-authored-by: Franco Fichtner <franco@lastsummer.de>
Removed the import statement from the widget to comply with the 24.7.3+ revisions Co-authored-by: Franco Fichtner <franco@lastsummer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt on rewrite for the WOL widget.
It's functionality is mostly the same as the old one, with the exception of ARP check which is now done via the API call.
As it's my first time with the JS, any inputs are welcome.
This should fix #4114.