sysutils/monit: bug fixing, status api response #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fbrendel
commented
Feb 15, 2018
fbrendel
commented
- SettingsController: fix faulty deletion of alerts, cleanup code, new function notificationAction to import system notification settings
- ServiceController: is a ApiMutableServiceControllerBase now
- StatusController: retruns the Monit status as JSON, old behaviour via 'html' parameter
- UI: accept FQDN as mailserver, 'Apply' doesn't restart Monit
fichtner
reviewed
Feb 15, 2018
| @@ -1,7 +1,7 @@ | |||
| <?php | |||
|
|
|||
| /** | |||
| * Copyright (C) 2017 EURO-LOG AG | |||
| * Copyright (C) 2017, 2018 EURO-LOG AG | |||
|
Looks good, but we should get the post-install hook out with a native config migration eventually. How much do you plan to edit this in the next 1-2 months? If you say not a lot we should merge it to core in March as discussed previously. |
|
Not much. Small bug fixes eventually. |
|
Merged, thanks! Ok, then it's a plan... :) |
fabianfrz
reviewed
Feb 15, 2018
| * can't do it via base_dialog | ||
| */ | ||
| $('<button class="btn btn-primary" id="btn_ImportSystemNotification" type="button" style="margin-left: 3px;">' + | ||
| '<b> Import System Notification </b>' + |
There was a problem hiding this comment.
this line is missing translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.