Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comments broken in #1876 #1908

Closed
BenHenning opened this issue Sep 25, 2020 · 5 comments · Fixed by #1917
Closed

Fix comments broken in #1876 #1908

BenHenning opened this issue Sep 25, 2020 · 5 comments · Fixed by #1917
Assignees
@Victor-Titan
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Sponsor Member

#1876 updated proto file comments incorrectly, e.g.:

// Maps from: data/src/main/java/org/oppia/data/backends/gae/model/GaeVoiceover.kt in voiceover.proto was incorrectly replaced with // Maps from: data/src/main/java/org.oppia.android.android/data/backends/gae/model/GaeVoiceover.kt. It should be: // Maps from: data/src/main/java/org/oppia/android/android/data/backends/gae/model/GaeVoiceover.kt.

This issue is tracking checking all proto files for these incorrect paths & fixing them.
@BenHenning BenHenning added the good first issue This item is good for new contributors to make their pull request. label Sep 25, 2020
@BenHenning
Copy link
Sponsor Member Author

/cc @rt4914 for potential SLoP project.

@BenHenning BenHenning mentioned this issue Sep 25, 2020
Merged
@rt4914 rt4914 added Priority: Nice-to-have This work item is nice to have for its milestone. SLoP 2020 labels Sep 25, 2020
@rt4914 rt4914 added this to the Backlog milestone Sep 25, 2020
@soamOne
Copy link
Contributor

soamOne commented Sep 26, 2020

Hey @BenHenning @rt4914 Can I work on this issue?

@Victor-Titan Victor-Titan mentioned this issue Sep 27, 2020
Closed
8 tasks
@Victor-Titan
Copy link
Contributor

I'd like to work on this issue

@BenHenning
Copy link
Sponsor Member Author

@soamOne it looks like @Victor-Titan already started on the issue. Feel free to pick another starter issue that's not yet claimed. :)

@soamOne
Copy link
Contributor

soamOne commented Sep 29, 2020

Yes got it @BenHenning :)

@Victor-Titan Victor-Titan mentioned this issue Sep 29, 2020
Merged
8 tasks
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Victor-Titan Victor-Titan

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1908:Changed comments in Proto files
Fix #1908:Changed comments in Proto files
5 participants
@rt4914 @BenHenning @Sarthak2601 @Victor-Titan @soamOne