Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1908:Changed comments in Proto files #1917

Merged
merged 1 commit into from Sep 30, 2020
Merged

Fix #1908:Changed comments in Proto files #1917

merged 1 commit into from Sep 30, 2020

Conversation

Victor-Titan
Copy link
Contributor

@Victor-Titan Victor-Titan commented Sep 29, 2020

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Victor-Titan Victor-Titan changed the title Fixed issue where android studio automatically changed .idea/codeStyl… Fix #1908:Changed comments in Proto files Sep 29, 2020
@Victor-Titan
Copy link
Contributor Author

@aggarwalpulkit596
Copy link
Contributor

@Victor-Titan it was fixed in the latest development or you just explicitly avoided that file?

@Victor-Titan
Copy link
Contributor Author

Victor-Titan commented Sep 29, 2020

@Victor-Titan it was fixed in the latest development or you just explicitly avoided that file?

It was fixed in the latest developement

@aggarwalpulkit596
Copy link
Contributor

LGTM Thanks :)

@prayutsu
Copy link
Contributor

@Victor-Titan Is your issue resolved?

@Victor-Titan
Copy link
Contributor Author

@prayutsu Yeah my issue is resolved

@prayutsu prayutsu self-requested a review September 29, 2020 15:15
@prayutsu
Copy link
Contributor

@Victor-Titan PR looks good to me, Thanks!!

@Victor-Titan
Copy link
Contributor Author

@aggarwalpulkit596 @prayutsu Since you've both approved the PR, do I have to tag someone else for it to be merged or the merge will occur when an authorized user is free to look at the list of approved PRs?

@prayutsu
Copy link
Contributor

@aggarwalpulkit596 @prayutsu Since you've both approved the PR, do I have to tag someone else for it to be merged or the merge will occur when an authorized user is free to look at the list of approved PRs?

Just wait for some time, It will get merged most probably by tomorrow morning

@aggarwalpulkit596
Copy link
Contributor

aggarwalpulkit596 commented Sep 29, 2020

@Victor-Titan it's usually merged by someone on the team but since this one is your first PR, I wanted one more member to approve the request before i merge the req.

@Victor-Titan
Copy link
Contributor Author

@aggarwalpulkit596 So should I tag someone else as well?

@rt4914 rt4914 self-assigned this Sep 29, 2020
@aggarwalpulkit596
Copy link
Contributor

I have already assigned it to @anandwana001.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Victor-Titan
@aggarwalpulkit596 You can merge this one.

@aggarwalpulkit596 aggarwalpulkit596 merged commit 340d7e2 into oppia:develop Sep 30, 2020
@Victor-Titan Victor-Titan deleted the fix-comments-broken branch September 30, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix comments broken in #1876
5 participants