Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1212: CompletedStoryList - Tablet (Portrait) (Lowfi) #1419

Merged
merged 9 commits into from
Aug 5, 2020
Merged

Fixes #1212: CompletedStoryList - Tablet (Portrait) (Lowfi) #1419

merged 9 commits into from
Aug 5, 2020

Conversation

MohamedMedhat1998
Copy link
Contributor

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

rt4914
rt4914 suggested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will need to write test cases for span count check. similar to ProfileChooserSpanTest for this file and all the rest of the earlier files too.

@rt4914 rt4914 assigned MohamedMedhat1998 and unassigned rt4914 Jun 29, 2020
@BenHenning
Copy link
Sponsor Member

@MohamedMedhat1998 please update this with the latest develop.

@MohamedMedhat1998
Merge remote-tracking branch 'origin/develop' into completed-story-ta…
7be32da 
…blet-port-lowfi

# Conflicts (Resolved):
#	app/src/main/res/values-land/integers.xml
#	app/src/main/res/values-sw600dp-port/integers.xml
#	app/src/main/res/values/integers.xml
@MohamedMedhat1998
Copy link
Contributor Author

@MohamedMedhat1998 please update this with the latest develop.

Done

@MohamedMedhat1998
Copy link
Contributor Author

LGTM, we will need to write test cases for span count check. similar to ProfileChooserSpanTest for this file and all the rest of the earlier files too.

@rt4914 Done

rt4914
rt4914 suggested changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some minor changes suggested.

app/src/main/java/org/oppia/app/completedstorylist/CompletedStoryListFragment.kt Outdated Show resolved Hide resolved
app/src/test/java/org/oppia/app/testing/CompletedStoryListSpanTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned MohamedMedhat1998 and unassigned rt4914 Aug 5, 2020
rt4914
rt4914 approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 assigned MohamedMedhat1998 and unassigned rt4914 Aug 5, 2020
@MohamedMedhat1998 MohamedMedhat1998 merged commit ce6c082 into develop Aug 5, 2020
@MohamedMedhat1998 MohamedMedhat1998 deleted the completed-story-tablet-port-lowfi branch August 5, 2020 19:05
@MohamedMedhat1998 MohamedMedhat1998 mentioned this pull request Aug 5, 2020
Merged
8 tasks
@MohamedMedhat1998
Merge remote-tracking branch 'origin/develop' into completed-story-ta…
dc6d5c5 
…blet-port-lowfi

# Conflicts (resolved):
#	app/src/main/res/values-land/integers.xml
#	app/src/main/res/values-sw600dp-land/integers.xml
#	app/src/main/res/values-sw600dp-port/integers.xml
#	app/src/main/res/values/integers.xml
#	app/src/main/res/values/strings.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@MohamedMedhat1998 MohamedMedhat1998

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CompletedStoryList - Tablet (Portrait) (Lowfi)
3 participants
@MohamedMedhat1998 @BenHenning @rt4914