Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompletedStoryList - Tablet (Portrait) (Lowfi) #1212

Closed
MohamedMedhat1998 opened this issue May 30, 2020 · 0 comments · Fixed by #1419
Closed

CompletedStoryList - Tablet (Portrait) (Lowfi) #1212

MohamedMedhat1998 opened this issue May 30, 2020 · 0 comments · Fixed by #1419
Assignees
@MohamedMedhat1998
Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@MohamedMedhat1998
Copy link
Contributor

MohamedMedhat1998 commented May 30, 2020 •
edited
Loading

Mocks: https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/370479e0-c774-4ca2-9864-bbf9f58d5672/P-Stories-Completed

Implement low-fi UI for CompletedStoryList tablet portrait mode

Target PR date: 30 July 2020
Target completion date: 3 August 2020
@MohamedMedhat1998 MohamedMedhat1998 added Where: Topics/Stories Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels May 30, 2020
@MohamedMedhat1998 MohamedMedhat1998 added this to the GSoC 2020 4.1: Milestone 3 milestone May 30, 2020
@MohamedMedhat1998 MohamedMedhat1998 self-assigned this May 30, 2020
@MohamedMedhat1998 MohamedMedhat1998 mentioned this issue Jun 27, 2020
Merged
8 tasks
MohamedMedhat1998 added a commit that referenced this issue Aug 5, 2020
@MohamedMedhat1998 @BenHenning
Fixes #1212: CompletedStoryList - Tablet (Portrait) (Lowfi) (#1419)
ce6c082 
* -Implemented low-fi UI for "CompletedStoryList" for landscape mode - tablet

* -Implemented low-fi UI for "CompletedStoryList" for portrait mode - tablet

* -added robolectric tests

* -some nit changes

Co-authored-by: Ben Henning <henning.benmax@gmail.com>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohamedMedhat1998 MohamedMedhat1998

Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1212: CompletedStoryList - Tablet (Portrait) (Lowfi) oppia/oppia-android
2 participants
@MohamedMedhat1998 @BenHenning