Fix #3056 & #3076: Create a BUILD.bazel file for the logging package in the utility module #3079

jonathanalvares9009 · 2021-04-10T18:57:05Z

Created a BUILD.bazel file for the logging package in the utility module.
Fixes #3056 and #3076

Explanation

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The PR follows the style guide.
The PR does not contain any unnecessary auto-generated code from Android Studio.
The PR is made from a branch that's not called "develop".
The PR is made from a branch that is up-to-date with "develop".
The PR's branch is based on "develop" and not on any other branch.
The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

BenHenning · 2021-04-13T02:13:33Z

@fsharpasharp can you take a first pass on this & assign it back after it looks good to you?

fsharpasharp

Nice work! This was a lot of libraries. Main thing here is to create another BUILD.bazel file for the firebase specific libraries.

fsharpasharp · 2021-04-13T17:28:46Z

utility/src/main/java/org/oppia/android/util/logging/BUILD.bazel

+    srcs = [
+        "LogLevel.kt",
+    ],
+    visibility = ["//:oppia_api_visibility"],


Is it possible to omit the visibility field and make this library private? It seems like it is only used within the package itself.

Ok I'll do it private

utility/src/main/java/org/oppia/android/util/logging/BUILD.bazel

jonathanalvares9009 · 2021-04-13T18:16:11Z

@fsharpasharp I'm getting this error can you help me?

jonathanalvares9009 · 2021-04-13T18:16:29Z

I'm trying to push to origin

fsharpasharp · 2021-04-13T18:21:39Z

Try pulling the latest develop branch first.

jonathanalvares9009 · 2021-04-14T04:21:36Z

I got this error after merging the latest changes into my local branch. I'm using GitHub oath tokens is it creating this issue @fsharpasharp ?

fsharpasharp · 2021-04-14T12:24:58Z

I got this error after merging the latest changes into my local branch. I'm using GitHub oath tokens is it creating this issue @fsharpasharp ?

Hm, could you check if there's anything on here that could help: https://stackoverflow.com/questions/64059610/how-to-resolve-refusing-to-allow-an-oauth-app-to-create-or-update-workflow-on

I'm not familiar with the issue.

jonathanalvares9009 · 2021-04-16T18:26:50Z

@fsharpasharp if I run bazel tests locally it passes for both testing and data but here it fails.

utility/src/main/java/org/oppia/android/util/logging/firebase/BUILD.bazel

BenHenning

Thanks @jonathanalvares9009. This LGTM.

The Bazel failure is unrelated to this PR, so we can ignore it.

vinitamurthi

LGTM, thanks

jonathanalvares9009 · 2021-04-27T08:31:02Z

@fsharpasharp can you review my PR?

fsharpasharp · 2021-04-27T09:12:14Z

Thanks @jonathanalvares9009 !

jonathanalvares9009 · 2021-04-28T05:06:26Z

@BenHenning could you merge the PR?

seanlip · 2021-04-28T05:09:06Z

@JonathanAlvares FYI there are a couple of failing checks (see the Robolectric unit tests).

fsharpasharp · 2021-05-07T17:36:45Z

Hey @jonathanalvares9009. Could you try updating the PR with the latest develop branch so we can look to get this merged? Also let me know if you're interested in doing more Bazel stuff as we look towards /domain and /app.

jonathanalvares9009 · 2021-05-08T05:16:56Z

@fsharpasharp yes I would like to work on Bazel issues

anandwana001 · 2021-05-10T05:08:26Z

Assigning @fsharpasharp to confirm and merge the PR if it's good to go.

fsharpasharp · 2021-05-10T07:33:44Z

Looks good to me @anandwana001. I don't think I'm able to merge though.

anandwana001 · 2021-05-10T08:06:12Z

Looks like few tests are failing, should I merge PR with these failure?

fsharpasharp · 2021-05-10T11:20:50Z

Looks like few tests are failing, should I merge PR with these failure?

Yes, I think we can merge the PR with the failure.

Created a BUILD.bazel file for the logging package in the utility module

c8e0b4f

jonathanalvares9009 requested review from BenHenning and vinitamurthi as code owners April 10, 2021 18:57

jonathanalvares9009 assigned vinitamurthi and BenHenning Apr 10, 2021

jonathanalvares9009 added 2 commits April 11, 2021 00:45

Resolved lint issue

20e4cc7

Resolved the failing tests

0799f46

BenHenning assigned fsharpasharp Apr 13, 2021

BenHenning requested a review from fsharpasharp April 13, 2021 02:13

BenHenning unassigned vinitamurthi and BenHenning Apr 13, 2021

fsharpasharp reviewed Apr 13, 2021

View reviewed changes

Latest changes

4f9e7f6

jonathanalvares9009 changed the title ~~Fix #3056: Create a BUILD.bazel file for the logging package in the utility module~~ Fix #3056 & #3076: Create a BUILD.bazel file for the logging package in the utility module Apr 16, 2021

jonathanalvares9009 added 2 commits April 16, 2021 21:11

Modularised utility

ba2b3cf

Fixed lint issues

12b39a5

jonathanalvares9009 requested a review from fsharpasharp April 16, 2021 18:26

fsharpasharp reviewed Apr 16, 2021

View reviewed changes

utility/src/main/java/org/oppia/android/util/logging/firebase/BUILD.bazel Show resolved Hide resolved

fsharpasharp approved these changes Apr 16, 2021

View reviewed changes

Removed the firebase prefix

3d4f34c

jonathanalvares9009 assigned vinitamurthi and BenHenning Apr 17, 2021

fsharpasharp removed their assignment Apr 17, 2021

jonathanalvares9009 added 2 commits April 24, 2021 13:17

Latest changes

47afc27

Removed redundant visibility label

c16800e

jonathanalvares9009 requested a review from BenHenning April 24, 2021 07:49

jonathanalvares9009 assigned BenHenning and unassigned jonathanalvares9009 Apr 24, 2021

Fix for failing tests

139e94b

BenHenning approved these changes Apr 27, 2021

View reviewed changes

BenHenning removed their assignment Apr 27, 2021

vinitamurthi approved these changes Apr 27, 2021

View reviewed changes

vinitamurthi removed their assignment Apr 27, 2021

fsharpasharp approved these changes Apr 27, 2021

View reviewed changes

fsharpasharp assigned jonathanalvares9009 and unassigned fsharpasharp Apr 27, 2021

jonathanalvares9009 added 2 commits April 28, 2021 15:07

Merge branch 'develop' into utility-logging-bazel

ee6d80e

Merge branch 'develop' into utility-logging-bazel

42b081e

anandwana001 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021

Merge branch 'develop' into utility-logging-bazel

52ef1d4

anandwana001 assigned fsharpasharp May 10, 2021

fsharpasharp removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 10, 2021

anandwana001 merged commit 7a97e50 into oppia:develop May 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #3056 & #3076: Create a BUILD.bazel file for the logging package in the utility module #3079

Fix #3056 & #3076: Create a BUILD.bazel file for the logging package in the utility module #3079

jonathanalvares9009 commented Apr 10, 2021 •

edited

BenHenning commented Apr 13, 2021

fsharpasharp left a comment

fsharpasharp Apr 13, 2021

jonathanalvares9009 Apr 13, 2021

jonathanalvares9009 Apr 16, 2021

jonathanalvares9009 commented Apr 13, 2021

jonathanalvares9009 commented Apr 13, 2021

fsharpasharp commented Apr 13, 2021

jonathanalvares9009 commented Apr 14, 2021

fsharpasharp commented Apr 14, 2021

jonathanalvares9009 commented Apr 16, 2021

BenHenning left a comment

vinitamurthi left a comment

jonathanalvares9009 commented Apr 27, 2021

fsharpasharp commented Apr 27, 2021

jonathanalvares9009 commented Apr 28, 2021

seanlip commented Apr 28, 2021

fsharpasharp commented May 7, 2021

jonathanalvares9009 commented May 8, 2021 •

edited

anandwana001 commented May 10, 2021

fsharpasharp commented May 10, 2021

anandwana001 commented May 10, 2021

fsharpasharp commented May 10, 2021

Fix #3056 & #3076: Create a BUILD.bazel file for the logging package in the utility module #3079

Fix #3056 & #3076: Create a BUILD.bazel file for the logging package in the utility module #3079

Conversation

jonathanalvares9009 commented Apr 10, 2021 • edited

Explanation

Checklist

BenHenning commented Apr 13, 2021

fsharpasharp left a comment

Choose a reason for hiding this comment

fsharpasharp Apr 13, 2021

Choose a reason for hiding this comment

jonathanalvares9009 Apr 13, 2021

Choose a reason for hiding this comment

jonathanalvares9009 Apr 16, 2021

Choose a reason for hiding this comment

jonathanalvares9009 commented Apr 13, 2021

jonathanalvares9009 commented Apr 13, 2021

fsharpasharp commented Apr 13, 2021

jonathanalvares9009 commented Apr 14, 2021

fsharpasharp commented Apr 14, 2021

jonathanalvares9009 commented Apr 16, 2021

BenHenning left a comment

Choose a reason for hiding this comment

vinitamurthi left a comment

Choose a reason for hiding this comment

jonathanalvares9009 commented Apr 27, 2021

fsharpasharp commented Apr 27, 2021

jonathanalvares9009 commented Apr 28, 2021

seanlip commented Apr 28, 2021

fsharpasharp commented May 7, 2021

jonathanalvares9009 commented May 8, 2021 • edited

anandwana001 commented May 10, 2021

fsharpasharp commented May 10, 2021

anandwana001 commented May 10, 2021

fsharpasharp commented May 10, 2021

jonathanalvares9009 commented Apr 10, 2021 •

edited

jonathanalvares9009 commented May 8, 2021 •

edited