-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3090: Removing context initialization from test setup #3111
Fix #3090: Removing context initialization from test setup #3111
Conversation
The Context is being setup manually in the setup method but this is unnecessary as it is already inject using Dagger.
Thanks, @sierisimo for sending your first PR.
|
Sorry for the inconvenience, I originally checked the checklist options I though I satisfied but later though it was something the reviewer will mark. For the espresso part, how can I show/confirm the test is espresso test? Sharing screenshot of the Thanks for your comment! |
As from the Icon in your screenshot, I can confirm this is the espresso test only. But, I think this will be helpful and learning too if you check here on how to run espresso test - https://developer.android.com/codelabs/advanced-android-kotlin-training-testing-basics#4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for those resources, I'm used to running tests but seeing the Thanks for your review! I'll wait for @BenHenning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sierisimo. LGTM.
Fix #3090:
Explanation
In the
ExplorationActivityTest
dagger has been setup and thecontext
is now injected, the line in the setup is unnecessary as noted in #3090Screenshot of tests
Checklist