Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3145: ExplorationActivityTest failing tests fixed #3147

Merged
merged 3 commits into from
May 7, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Apr 30, 2021

Explanation

Fixes #3145

The two tests were failing because the createVoiceoverMappingsFromJson was returning map for empty content-ids too.

This PR updates the implementation to check if voiceover/contentid json is empty then do not add that as Voiceover to the map.

Screenshot

In current develop the audio icon is available in toolbar in all explorations. The below screenshot shows that it is no more visible for for states which do not contain audio.

Screenshot 2021-04-30 at 11 50 37 AM

Screenshot 2021-05-04 at 7 15 08 PM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from BenHenning as a code owner April 30, 2021 06:20
@rt4914 rt4914 changed the title Fixes #3145: ExplorationActivityTest failing tests fixed. Fixes #3145: ExplorationActivityTest failing tests fixed Apr 30, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914 & nice catch. I would ask for a test to be added, but given this is temporary code I think time is better spent not bothering if ExplorationActivityTest confirms the fix.

Just have 1 comment to address--PTAL.

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning May 1, 2021
@rt4914 rt4914 assigned BenHenning and unassigned rt4914 May 4, 2021
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914. LGTM!

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning May 6, 2021
@anandwana001 anandwana001 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
@rt4914 rt4914 removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
@rt4914 rt4914 merged commit afe8882 into develop May 7, 2021
@rt4914 rt4914 deleted the fix-audio-toolbar-icon-bug branch May 7, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio related tests failing on espresso
3 participants