Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #414: Add StringToFractionParserTest #3154

Merged
merged 7 commits into from
May 16, 2021
Merged

Fix #414: Add StringToFractionParserTest #3154

merged 7 commits into from
May 16, 2021

Conversation

viktoriias
Copy link
Contributor

@viktoriias viktoriias commented May 1, 2021 •
edited

Explanation

Fixes #414: Add unit tests for StringToFractionParser.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@viktoriias viktoriias closed this May 2, 2021
@viktoriias viktoriias reopened this May 2, 2021
@viktoriias viktoriias marked this pull request as draft May 2, 2021 17:14
@viktoriias viktoriias closed this May 2, 2021
@viktoriias viktoriias reopened this May 2, 2021
@viktoriias viktoriias changed the title Add StringToFractionParserTest. Fix #414: Add StringToFractionParserTest May 3, 2021
@viktoriias viktoriias closed this May 3, 2021
@viktoriias viktoriias reopened this May 3, 2021
@viktoriias viktoriias marked this pull request as ready for review May 6, 2021 00:17
@viktoriias
Copy link
Contributor Author

@BenHenning Please review.
I closed #3112 because of sync issues, but your comments are addressed.
Checks here are failing because of #3157

@BenHenning
Copy link
Sponsor Member

Sorry, been really busy with non-work items this week. Will need to take a look later in the week.

@anandwana001 anandwana001 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
@anandwana001 anandwana001 removed the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 7, 2021
BenHenning
BenHenning requested changes May 8, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viktoriias! I think this looks really good. Just had one nit on test naming--PTAL.

app/src/test/java/org/oppia/android/app/parser/StringToFractionParserTest.kt Outdated Show resolved Hide resolved
@BenHenning BenHenning assigned viktoriias and unassigned BenHenning May 8, 2021
@viktoriias viktoriias requested a review from rt4914 as a code owner May 8, 2021 04:56
@viktoriias viktoriias requested a review from BenHenning May 8, 2021 06:20
@viktoriias viktoriias assigned rt4914 and BenHenning and unassigned viktoriias May 8, 2021
rt4914
rt4914 approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment May 10, 2021
@viktoriias
Copy link
Contributor Author

@BenHenning PTAL

BenHenning
BenHenning approved these changes May 16, 2021
View reviewed changes
Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies @viktoriias I've been traveling this week. I think the updated test names look excellent! The PR LGTM, thanks!

@BenHenning BenHenning merged commit 96b119d into oppia:develop May 16, 2021
rt4914 added a commit that referenced this pull request May 18, 2021
@rt4914
Revert "Fix #414: Add StringToFractionParserTest (#3154)"
b76b657 
This reverts commit 96b119d.
@rt4914 rt4914 mentioned this pull request May 18, 2021
Merged
rt4914 added a commit that referenced this pull request May 18, 2021
@rt4914
Revert "Fix #414: Add StringToFractionParserTest (#3154)" (#3196)
73c9d0d 
This reverts commit 96b119d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@BenHenning BenHenning BenHenning approved these changes

@anandwana001 anandwana001 Awaiting requested review from anandwana001

Assignees

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for whitespace & fractions patterns
4 participants
@viktoriias @BenHenning @rt4914 @anandwana001