Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3078: Create BUILD.bazel in caching package in the utility module #3182

Merged
merged 5 commits into from
May 17, 2021

Conversation

jonathanalvares9009
Copy link
Contributor

Created BUILD.bazel in caching package in the utility module.
Fixes #3078

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@jonathanalvares9009
Copy link
Contributor Author

Hi @fsharpasharp are you going to open some more Bazel issues?

@fsharpasharp
Copy link
Contributor

@jonathanalvares9009 you can check out parser. It's a little more complicated since the packages weren't as independent as I thought. I'll file an issue for that one soon.

@fsharpasharp
Copy link
Contributor

Some failures seem to be related to caching/testing. Try creating a BUILD.bazel file in that directory as well.

@jonathanalvares9009
Copy link
Contributor Author

Hi @fsharpasharp and @anandwana001 I have fixed the errors

@oppiabot
Copy link

oppiabot bot commented May 13, 2021

Unassigning @fsharpasharp since they have already approved the PR.

@jonathanalvares9009
Copy link
Contributor Author

@anandwana001 could you review my PR?

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jonathanalvares9009 for working on Bazel issues.
Much Appreciated

@anandwana001 anandwana001 merged commit dca512e into oppia:develop May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a BUILD.bazel file in the caching directory of the utility module [Blocked by #3056]
3 participants