Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #40 & #42: Highfi buttons part 1 #3197

Merged
merged 8 commits into from
May 19, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 18, 2021

Explanation

Fixes part of #40
Fixes part of #42

This PR works on the highfi part of Return to Topic and Replay button. Both of these buttons appear only at the end of question/exploration player session and therefore they can never have a split view. Also, the top-margins are consistent across all combinations and therefore they have been defined only in values/dimens and not in any other dimens file.

Resources

Replay + Return to Topic Button

Exploration Mobile-Portrait
Exploration Mobile-Landscape
Exploration Tablet-Portrait
Exploration Tablet-Landscape

Question Mobile-Portrait
Question Mobile-Landscape
Question Tablet-Portrait
Question Tablet-Landscape

All other buttons (Next/Previous/Submit/Continue)

Exploration Mobile-Portrait
Exploration Mobile-Landscape
Exploration Tablet-Portrait
Exploration Tablet-Landscape

Question Mobile-Portrait
Question Mobile-Landscape
Question Tablet-Portrait
Question Tablet-Landscape

Split View Tablet-Portrait
Split View Tablet-Landscape

Buttons Specs

Screenshots

=======

=======

=======

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 self-assigned this May 19, 2021
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 19, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented May 19, 2021

@anandwana001 Check the last commit and 3109a12 and screenshot and that should suffice now.

Thanks.

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 May 19, 2021
@rt4914 rt4914 requested a review from anandwana001 May 19, 2021 16:56
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @rt4914

@anandwana001 anandwana001 merged commit e193df7 into develop May 19, 2021
@anandwana001 anandwana001 deleted the highfi-buttons-part-1 branch May 19, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants