Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3206: Hi-fi FAQ List #3207

Merged
merged 6 commits into from
May 21, 2021
Merged

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented May 20, 2021

Explanation

Fixes #3206

https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/69ef4e61-dd48-42de-9fb4-1ab4a5ebe996/specs/

https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/63a98a9c-3b46-4ba6-87d0-2f6e7c70bbe4/specs/

Screenshots

Screenshot_1621478239
Screenshot_1621478227
Screenshot_1621513940
Screenshot_1621513930

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 requested a review from rt4914 as a code owner May 20, 2021 02:42
@anandwana001 anandwana001 changed the title Fix #3206: Hi-fi Faq List Fix #3206: Hi-fi FAQ List May 20, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1621496586

In land-tablet devices irrespective of number of items the middle-white area should be fully stretched till bottom.

@oppiabot oppiabot bot unassigned rt4914 May 20, 2021
@oppiabot
Copy link

oppiabot bot commented May 20, 2021

Unassigning @rt4914 since the review is done.

@oppiabot
Copy link

oppiabot bot commented May 20, 2021

Hi @anandwana001, it looks like some changes were requested on this pull request by @rt4914. PTAL. Thanks!

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 20, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous PR review I wrote it incorrectly, actually the file should be only for sw600dp-land as the portrait UI does not contain any grey background. Apologies for confusion.
Everything else looks good just shift the sw600dp file to sw600dp-land file

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 May 21, 2021
@oppiabot oppiabot bot added the PR: LGTM label May 21, 2021
@oppiabot
Copy link

oppiabot bot commented May 21, 2021

Hi @anandwana001, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@anandwana001 anandwana001 enabled auto-merge (squash) May 21, 2021 08:05
@anandwana001 anandwana001 merged commit d056fb2 into oppia:develop May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hi-fi FAQ List
2 participants