Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3031 : Glide loading small image #3211

Merged
merged 2 commits into from
May 21, 2021

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented May 20, 2021

Explanation

Fixes #3031

TODO
Write test case for scaleType.
Need to create a custom mather by passing imageView item and test match the scaleType.

Screenshot

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM waiting for test case.

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 May 20, 2021
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 20, 2021
@anandwana001
Copy link
Contributor Author

@rt4914 Added 2 test case, could we have good first issues for this making this as a base PR or do we require all the test in this PR only?

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Normally we prefer tests in the PR itself but for this PR actually creating good-first-issues is good considering the tests are straightforward and across multiple files.

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 May 21, 2021
@oppiabot oppiabot bot added the PR: LGTM label May 21, 2021
@oppiabot
Copy link

oppiabot bot commented May 21, 2021

Hi @anandwana001, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@anandwana001 anandwana001 merged commit a316260 into oppia:develop May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glide loading small image
2 participants