-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3031 : Glide loading small image #3211
Fix #3031 : Glide loading small image #3211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM waiting for test case.
@rt4914 Added 2 test case, could we have good first issues for this making this as a base PR or do we require all the test in this PR only? |
app/src/sharedTest/java/org/oppia/android/app/topic/revision/TopicRevisionFragmentTest.kt
Show resolved
Hide resolved
testing/src/main/java/org/oppia/android/testing/espresso/ImageViewMatcher.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Normally we prefer tests in the PR itself but for this PR actually creating good-first-issues is good considering the tests are straightforward and across multiple files.
Hi @anandwana001, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes #3031
TODO
Write test case for scaleType.
Need to create a custom mather by passing imageView item and test match the scaleType.
Screenshot
Checklist