Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2326: A11y changes for Topic Practice Tab #3226

Merged
merged 1 commit into from
May 23, 2021
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 23, 2021

Explanation

Fixes #2326
All the issues mentioned inside the original issue were already passing but I found a new error which is related to min-clickable-height. Therefore this PR updates the minHeight to 48dp.

Solved issue

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented May 23, 2021

Unassigning @anandwana001 since they have already approved the PR.

@rt4914 rt4914 merged commit 66de96d into develop May 23, 2021
@rt4914 rt4914 deleted the a11y-practice branch May 23, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in Views inside Practice Tab [A11y]
3 participants