Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2817: [A11y] Added label for ReadingTextSizeActivity #3227

Merged
merged 1 commit into from
May 23, 2021
Merged

Fixes #2817: [A11y] Added label for ReadingTextSizeActivity #3227

merged 1 commit into from
May 23, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 23, 2021

Explanation

Fix #2817: [A11y] Added label for ReadingTextSizeActivity

Screenshot 2021-05-24 at 1 37 48 AM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

rt4914
rt4914 commented May 23, 2021
View reviewed changes
app/src/main/res/values/strings.xml
@@ -341,6 +341,7 @@
<!-- OptionsActivity -->
<string name="app_language_activity_title">App Language</string>
<string name="audio_language_activity_title">Default Audio Language</string>
<string name="reading_text_size_activity_title">Reading Text Size</string>
<string name="title_reading_text_size">Reading Text Size</string>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using this as it is part of fragment and also cannot rename this as as per our convention the labels are named as <name>_activity_title.

anandwana001
anandwana001 approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented May 23, 2021

Unassigning @anandwana001 since they have already approved the PR.

@rt4914 rt4914 merged commit ec622a8 into develop May 23, 2021
@rt4914 rt4914 deleted the a11y-reading-text-size-label branch May 23, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

@Arjupta Arjupta Awaiting requested review from Arjupta

Assignees

@Arjupta Arjupta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for ReadingTextSizeActivity
3 participants
@rt4914 @anandwana001 @Arjupta