Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RunAllTests] Fixing Bazel CI Actions Error #3228

Merged
merged 5 commits into from
May 24, 2021
Merged

[RunAllTests] Fixing Bazel CI Actions Error #3228

merged 5 commits into from
May 24, 2021

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented May 23, 2021 •
edited

Explanation

  1. Update PinView host for fixing Bazel Couiser Timed Out error coming in all PR actions
  2. Added ImageViewMatcher file to test deps

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

rt4914
rt4914 approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 removed their assignment May 23, 2021
@anandwana001 anandwana001 changed the title Pinview host update [RunAllTest] Pinview host update May 23, 2021
@anandwana001 anandwana001 changed the title [RunAllTest] Pinview host update [RunAllTests] Pinview host update May 23, 2021
@anandwana001 anandwana001 mentioned this pull request May 24, 2021
Closed
@anandwana001 anandwana001 changed the title [RunAllTests] Pinview host update [RunAllTests] Fixing Bazel CI Actions Error May 24, 2021
@anandwana001
Copy link
Contributor Author

@fsharpasharp PTAL

@anandwana001 anandwana001 enabled auto-merge (squash) May 24, 2021 10:35
fsharpasharp
fsharpasharp approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@fsharpasharp fsharpasharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@anandwana001 anandwana001 merged commit ed8e42b into oppia:develop May 24, 2021
@BenHenning BenHenning mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@fsharpasharp fsharpasharp fsharpasharp approved these changes

Assignees

@fsharpasharp fsharpasharp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anandwana001 @rt4914 @fsharpasharp