Fix #2637: [A11y] Marquee Toolbar Fix for Revision Card and Story Activity #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandwana001
approved these changes
May 23, 2021
| @@ -76,7 +76,7 @@ class StoryFragmentPresenter @Inject constructor( | |||
| (activity as StoryActivity).finish() | |||
| } | |||
|
|
|||
| binding.storyToolbar.setOnClickListener { | |||
| binding.storyToolbarTitle.setOnClickListener { | |||
There was a problem hiding this comment.
any test case to update for this?
|
Unassigning @anandwana001 since they have already approved the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix #2637: [A11y] Marquee Toolbar Fix for Revision Card and Story Activity
Before video is available in issue.
NOTE: The
Story Toolbarissue has not been filed anywhere because currently we do not have a story name which goes out of toolbar size but considering that the implementation is exactly same asRevision CardI have fixed it forStory Activitytoo.After Video
correct_a11y_revision_card.mp4
device-2021-05-24-034252.mp4
Checklist