Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3231: Updated margin in styles #3232

Merged
merged 2 commits into from
May 24, 2021
Merged

Fixes #3231: Updated margin in styles #3232

merged 2 commits into from
May 24, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 23, 2021 •
edited

Explanation

Fixes #3231: Updated margin in styles

Check the issue which display the button displacement.

New Screenshots


Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from anandwana001 May 23, 2021 23:12
@rt4914
Copy link
Contributor Author

rt4914 commented May 23, 2021

@anandwana001 You can merge this after approval.

anandwana001
anandwana001 approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 changed the title Fixes #3232: Updated margin in styles Fixes #3231: Updated margin in styles May 23, 2021
@rt4914 rt4914 enabled auto-merge (squash) May 23, 2021 23:26
@oppiabot
Copy link

oppiabot bot commented May 23, 2021

Unassigning @anandwana001 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label May 23, 2021
anandwana001
anandwana001 suggested changes May 24, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking from merging as there are test failing

@oppiabot oppiabot bot removed the PR: LGTM label May 24, 2021
@oppiabot
Copy link

oppiabot bot commented May 24, 2021

Hi, @rt4914, the LGTM Label has been removed because the changes were requested on this PR. Thanks!.

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 May 24, 2021
anandwana001
anandwana001 approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 merged commit 74e4aba into develop May 24, 2021
@rt4914 rt4914 deleted the fixed-button-margins branch May 24, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button Margin Updates in Style
2 participants
@rt4914 @anandwana001