Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2823: Profile list activity label #3244

Merged
merged 2 commits into from
May 25, 2021
Merged

Fix #2823: Profile list activity label #3244

merged 2 commits into from
May 25, 2021

Conversation

pravesh00
Copy link
Contributor

@pravesh00 pravesh00 commented May 25, 2021 •
edited

Explanation

Fixes #2823: Profile list activity label added

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@pravesh00 pravesh00 requested a review from rt4914 as a code owner May 25, 2021 11:50
@pravesh00 pravesh00 mentioned this pull request May 25, 2021
Closed
8 tasks
@pravesh00
Copy link
Contributor Author

pravesh00 commented May 25, 2021 •
edited

PTAL @rt4914 @anandwana001 @Victor-Titan

@pravesh00 pravesh00 changed the title FIX #2823: Profile list activity label Fix #2823: Profile list activity label May 25, 2021
rt4914
rt4914 suggested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested nit change. Otherwise looks good.

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/settings/profile/ProfileListActivityTest.kt Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned pravesh00 and unassigned rt4914 May 25, 2021
rt4914
rt4914 approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 enabled auto-merge (squash) May 25, 2021 20:21
@rt4914 rt4914 merged commit 8134229 into oppia:develop May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@pravesh00 pravesh00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[A11y] Add label for ProfileListActivity
2 participants
@pravesh00 @rt4914