Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3142: No use of espresso.intent in ProfileChooserFragmentLocalTest #3257

Merged
merged 1 commit into from
May 28, 2021
Merged

Fix #3142: No use of espresso.intent in ProfileChooserFragmentLocalTest #3257

merged 1 commit into from
May 28, 2021

Conversation

pravesh00
Copy link
Contributor

Explanation

Fixes #3142 : No use of espresso.intent in ProfileChooserFragmentLocalTest

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@pravesh00 pravesh00 requested a review from rt4914 as a code owner May 27, 2021 12:04
@pravesh00
Copy link
Contributor Author

@anandwana001 PTAL was there something more to this issue or this is correct?

anandwana001
anandwana001 approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @pravesh00

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 May 28, 2021
rt4914
rt4914 approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit d25d9e0 into oppia:develop May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No use of espresso.intent in ProfileChooserFragmentLocalTest
3 participants
@pravesh00 @rt4914 @anandwana001