[RunAllTests] Fix #2923: Remove direct bintray/jcenter dependence #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
changed the title
|
Needed to retrigger the build since it was hanging on identifying Bazel targets again. The re-run requires a second re-run of Gradle tests since it hit a known Gradle test flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2923
Explanation
This PR removes dependence on JCenter/Bintray given the service is now frozen & can no longer receive updated dependencies (and will likely be turned down at some point). This required effectively no work on the Bazel side since it seems Bazel builds already didn't depend on JCenter as of #3249.
Our CircularImageview dependency was the only one exclusively available on JCenter, but we fortunately already had an Oppia-specific fork of it that, with a few updates, became jitpack compatible. Interestingly, we also had a bunch of other dependencies coming from JCenter that could easily be replaced with Maven Central. This will likely improve build reliability since JCenter has had some service issues over the past few months.