[RunAllTests] Fix #3217, part of #2923: migrate flexbox dependency to pull from Google's Maven repository instead of JCenter/bintray #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update flexbox to use the Google Maven dependency instead of JCenter.
Update flexbox layout dependency to use Google Maven instead of JCenter.
BenHenning
changed the title
FIx linter error.
Fix flexbox dependency reference since it's been updated.
|
This PR fixing #3217 too |
BenHenning
changed the title
|
Thanks @anandwana001. Updated the PR to mark that issue as fixed. The 2 Bazel failures here seem unrelated to the change, and I don't think either test would be affected by this, anyway, so I'm not going to re-run them. |
|
The build seems to be working correctly locally, and relevant CI are passing. @rt4914 & @fsharpasharp PTAL. |
fsharpasharp
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3217.
Fix part of #2923.
Explanation
This updates the Bazel & Gradle builds to use the new version & group ID for flexbox-layout so that the build pulls the dependency from Google Maven instead of JCenter/Bintray (per google/flexbox-layout#566 (comment)). While Bintray is promising long-term hosting for dependencies, it's immutable which means new versions can't be received. Beyond that, we've had reliability issues with our JCenter/Bintray dependencies. This removes one JCenter/Bintray dependency.
This should have no side effects with the current project since 3.0.0 is meant to be identical with 2.0.1. I'll be using CI & a manual verification of the APK (to ensure the walkthrough experience, our only screen that uses flexbox layout, works correctly) for validity checking.