Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2403: Resolve ktlint max line in player test package #3260

Merged
merged 16 commits into from
Jun 3, 2021
Merged

Fix #2403: Resolve ktlint max line in player test package #3260

merged 16 commits into from
Jun 3, 2021

Conversation

pravesh00
Copy link
Contributor

Explanation

Fixes #2403 : Resolve ktlint max line in player test package

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@pravesh00 pravesh00 requested a review from rt4914 as a code owner May 28, 2021 10:45
@pravesh00
Copy link
Contributor Author

@rt4914 I have tried to reduce the names of fun as much logical with the max limit as I could PTAL and tell me if I can make it better.

anandwana001
anandwana001 suggested changes May 28, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pravesh00

Left suggestions

app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/state/StateFragmentTest.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 assigned pravesh00 and unassigned rt4914 May 28, 2021
@pravesh00
Copy link
Contributor Author

@anandwana001 PTAL

@oppiabot oppiabot bot assigned anandwana001 and unassigned pravesh00 May 31, 2021
@oppiabot
Copy link

oppiabot bot commented May 31, 2021

Unassigning @pravesh00 since a re-review was requested. @pravesh00, please make sure you have addressed all review comments. Thanks!

@anandwana001
Copy link
Contributor

@pravesh00 Could you please comment on my suggestions with done if completed or some comments if any of my comment is not clear.

@pravesh00
Copy link
Contributor Author

@anandwana001 PTAL

@oppiabot oppiabot bot assigned anandwana001 and unassigned pravesh00 Jun 2, 2021
@oppiabot
Copy link

oppiabot bot commented Jun 2, 2021

Unassigning @pravesh00 since a re-review was requested. @pravesh00, please make sure you have addressed all review comments. Thanks!

rt4914
rt4914 suggested changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pravesh00 Suggested changes.

app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
app/src/sharedTest/java/org/oppia/android/app/player/exploration/ExplorationActivityTest.kt Outdated Show resolved Hide resolved
@pravesh00
Copy link
Contributor Author

@rt4914 PTAL

@oppiabot oppiabot bot assigned rt4914 and unassigned pravesh00 Jun 2, 2021
@oppiabot
Copy link

oppiabot bot commented Jun 2, 2021

Unassigning @pravesh00 since a re-review was requested. @pravesh00, please make sure you have addressed all review comments. Thanks!

rt4914
rt4914 approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 removed their assignment Jun 2, 2021
anandwana001
anandwana001 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 merged commit 7510a90 into oppia:develop Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve ktlint max line in player test package
3 participants
@pravesh00 @anandwana001 @rt4914