Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3294: Create Developer options menu item in Navigation Drawer #3314

Merged
merged 47 commits into from
Jun 30, 2021

Conversation

yashraj-01
Copy link
Contributor

@yashraj-01 yashraj-01 commented Jun 11, 2021

Explanation

Fixes #3294: Create Developer options menu item in Navigation Drawer. The feature is backed by tests in NavigationDrawerActivityProdTest and NavigationDrawerActivityDevTest.

Mock link: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/be13be5c-d0c5-4430-bda2-670d48a36b53/

Screenshots

  • GIF showing the Developer Options menu item

  • Espresso Test result for NavigationDrawerActivityProdTest
    Screenshot from 2021-06-22 23-38-22

  • Robolectric Test result for NavigationDrawerActivityProdTest
    Screenshot from 2021-06-22 23-44-51

  • Espresso Test result for NavigationDrawerActivityDebugTest
    Screenshot from 2021-06-26 23-57-55

  • Robolectric Test result for NavigationDrawerActivityDebugTest
    Screenshot from 2021-06-26 23-59-05

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@yashraj-01
Copy link
Contributor Author

yashraj-01 commented Jun 11, 2021

There are changes in a lot of files but most of them have same changes which is the addition of DeveloperOptionsStarterModule and DeveloperOptionsModule in the TestApplicationComponent in the test files. Only the following files contain the actual relevant changes:

  • AndroidManifest.xml
  • DeveloperOptionsActivity.kt
  • DeveloperOptionsActivityPresenter.kt
  • DeveloperOptionsFragment.kt
  • DeveloperOptionsFragmentPresenter.kt
  • ExitProfileDialogFragment.kt
  • ExitProfileDialogInterface.kt
  • NavigationDrawerFooterViewModel.kt
  • NavigationDrawerFragment.kt
  • NavigationDrawerFragmentPresenter.kt
  • FragmentComponent.kt
  • developer_options_activity.xml
  • developer_options_fragment.xml
  • drawer_fragment.xml
  • colors.xml
  • strings.xml
  • DeveloperOptionsActivityTest.kt
  • NavigationDrawerActivityProdTest.kt
  • NavigationDrawerActivityDebugTest.kt
  • arguments.proto

@yashraj-01 yashraj-01 linked an issue Jun 11, 2021 that may be closed by this pull request
@yashraj-01 yashraj-01 changed the title Fix #3294: Create Developer options menu item in Navigation Drawer Fix #3294: Create Developer options menu item in Navigation Drawer [BLOCKED on #3313] Jun 15, 2021
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @yashraj-01. Suggested some changes.
Also, some test cases seem to be failing -- PTAL.

@yashraj-01
Copy link
Contributor Author

@vinitamurthi I have added the TODOs and filed the issue (#3382). PTAL.

@yashraj-01
Copy link
Contributor Author

Does this actually require my input @yashraj-01 / @Sarthak2601? Removing myself for now, but if my review is needed please reassign me with specifics on what you'd like me to review.

I assigned you for clarification on Optional. But it is resolved for now. I have filed an issue for that. Apologies for the inconvenience.

@yashraj-01 yashraj-01 requested review from Sarthak2601 and removed request for BenHenning June 28, 2021 21:05
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yashraj-01

@rt4914 rt4914 assigned yashraj-01 and unassigned rt4914 and vinitamurthi Jun 29, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jun 29, 2021

@yashraj-01 @Sarthak2601 Merge this once all tests pass.

@oppiabot
Copy link

oppiabot bot commented Jun 29, 2021

Assigning @vinitamurthi for code owner reviews. Thanks!

Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Sarthak2601
Copy link
Contributor

@vinitamurthi PTAL for code owners, thanks!

Copy link
Contributor

@vinitamurthi vinitamurthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly checked if the TODOs have been added and looks like they have so LGTM!

@vinitamurthi
Copy link
Contributor

Ah sorry I see there was a proto as well. Proto also LGTM. Merging this now!

@vinitamurthi vinitamurthi merged commit 3ad2ccb into develop Jun 30, 2021
@vinitamurthi vinitamurthi deleted the developer-options-menu-item branch June 30, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Developer Options Menu Item in Navigation Drawer
6 participants