-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3294: Create Developer options menu item in Navigation Drawer #3314
Conversation
There are changes in a lot of files but most of them have same changes which is the addition of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @yashraj-01. Suggested some changes.
Also, some test cases seem to be failing -- PTAL.
app/src/main/java/org/oppia/android/app/devoptions/DeveloperOptionsActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/drawer/NavigationDrawerFragmentPresenter.kt
Show resolved
Hide resolved
@vinitamurthi I have added the TODOs and filed the issue (#3382). PTAL. |
I assigned you for clarification on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yashraj-01
@yashraj-01 @Sarthak2601 Merge this once all tests pass. |
Assigning @vinitamurthi for code owner reviews. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@vinitamurthi PTAL for code owners, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mainly checked if the TODOs have been added and looks like they have so LGTM!
Ah sorry I see there was a proto as well. Proto also LGTM. Merging this now! |
Explanation
Fixes #3294: Create Developer options menu item in Navigation Drawer. The feature is backed by tests in
NavigationDrawerActivityProdTest
andNavigationDrawerActivityDevTest
.Mock link: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/be13be5c-d0c5-4430-bda2-670d48a36b53/
Screenshots
GIF showing the Developer Options menu item
Espresso Test result for
NavigationDrawerActivityProdTest
Robolectric Test result for
NavigationDrawerActivityProdTest
Espresso Test result for
NavigationDrawerActivityDebugTest
Robolectric Test result for
NavigationDrawerActivityDebugTest
Checklist