-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3297: Implement Force Crash App Feature #3339
Conversation
Thanks @yashraj-01! Still LGTM--I have no other comments to add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I was earlier got assigned due to merge from the develop branch, though LGTM, assign back your mentor for further action.
@Sarthak2601 all the reviewers have approved the PR. Can you please merge it once all the checks pass? Thanks. |
Explanation
Fixes #3297: Implemented force crashing of app.
Note for reviewers
In
testDeveloperOptionsFragment_clickForceCrash_assertException
we have asserted the message ofexception.cause
. This is because Espresso throwsPerformException
which is caused by theRuntimeException
which we are throwing. You can check out the references below:Screenshots
Working
Espresso tests --
DeveloperOptuionsActivityTest
Robolectric tests --
DeveloperOptuionsActivityTest
Checklist