Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3297: Implement Force Crash App Feature #3339

Merged
merged 89 commits into from
Jul 7, 2021
Merged

Conversation

yashraj-01
Copy link
Contributor

@yashraj-01 yashraj-01 commented Jun 17, 2021

Explanation

Fixes #3297: Implemented force crashing of app.

Note for reviewers
In testDeveloperOptionsFragment_clickForceCrash_assertException we have asserted the message of exception.cause. This is because Espresso throws PerformException which is caused by the RuntimeException which we are throwing. You can check out the references below:

Screenshots

  • Working

  • Espresso tests -- DeveloperOptuionsActivityTest
    Screenshot from 2021-06-18 02-45-17

  • Robolectric tests -- DeveloperOptuionsActivityTest
    Screenshot from 2021-06-18 02-43-21

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@BenHenning
Copy link
Sponsor Member

Thanks @yashraj-01! Still LGTM--I have no other comments to add.

@BenHenning BenHenning removed their assignment Jul 1, 2021
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned yashraj-01 and unassigned rt4914 Jul 1, 2021
@oppiabot oppiabot bot added the PR: LGTM label Jul 1, 2021
Base automatically changed from developer-options-menu to develop July 6, 2021 00:26
@yashraj-01 yashraj-01 assigned anandwana001 and unassigned yashraj-01 Jul 6, 2021
@yashraj-01 yashraj-01 changed the title Fix #3297: Implement Force Crash App Feature [BLOCKED on #3331] Fix #3297: Implement Force Crash App Feature Jul 6, 2021
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I was earlier got assigned due to merge from the develop branch, though LGTM, assign back your mentor for further action.

@yashraj-01
Copy link
Contributor Author

yashraj-01 commented Jul 6, 2021

@Sarthak2601 all the reviewers have approved the PR. Can you please merge it once all the checks pass? Thanks.

@yashraj-01 yashraj-01 assigned Sarthak2601 and unassigned yashraj-01 Jul 6, 2021
@Sarthak2601 Sarthak2601 merged commit d378399 into develop Jul 7, 2021
@Sarthak2601 Sarthak2601 deleted the force-crash-app branch July 7, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Force Crash App Feature
6 participants