Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3280: Create a BUILD.bazel file in domain module in util package #3344

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

jonathanalvares9009
Copy link
Contributor

Created a BUILD.bazel file in domain module in util package.
Fixes #3280

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@fsharpasharp fsharpasharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great.

@oppiabot
Copy link

oppiabot bot commented Jun 21, 2021

Unassigning @fsharpasharp since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jun 21, 2021
@anandwana001
Copy link
Contributor

Re-running the jobs, all checks must pass before merge

@jonathanalvares9009
Copy link
Contributor Author

Hi @anandwana001, it passed all tests

@anandwana001 anandwana001 merged commit 11abf3b into oppia:develop Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a BUILD.bazel file for domain/util
3 participants