-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3298, #3299 and #3301: Introduce UI for MarkChaptersCompleted, MarkStoriesCompleted and MarkTopicsCompleted #3347
Conversation
Thanks @BenHenning for the reviews. Also, I have made the last nit change you mentioned. |
Ah! Actually, when I requested you for review, I didn't know about the code owner thing. Also, since you have requested changes on this PR I think you have to approve them also. Assigning you now. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. One nit suggested.
) { | ||
bindingAdapter.notifyItemRangeChanged( | ||
chapterIndex, | ||
/*itemCount = */nextStoryIndex - chapterIndex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit space /*itemCount = */ nextStoryIndex - chapterIndex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Also, thanks for the review.
Assigning @anandwana001 for code owner reviews. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
Fixes #3298, #3299 and #3301: Introduced UI for MarkChaptersCompleted, MarkStoriesCompleted and MarkTopicsCompleted.
Note:
This PR only introduces the UI and the logic for displaying the list of chapters/stories/topics. All the interaction and modifying progress logic will be tracked by issues Implement logic for marking chapters completed #3303, Implement logic for marking stories completed #3305 and Implement logic for marking topics completed #3306.
In this PR I have added all the newly added kotlin files to
test_file_exemptions.textproto
except:DeveloperOptionsActivity
MarkChaptersCompletedActivity
MarkStoriesCompletedActivity
MarkTopicsCompletedActivity
ViewEventLogsActivity
Mock links:
Screenshots
DeveloperOptionsActivityTest
MarkChaptersCompletedActivityTest
MarkStoriesCompletedActivityTest
MarkTopicsCompletedActivityTest
ModifyLessonProgressControllerTest
Checklist