Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #1587: Made some intent/bundle/saved/tags instance keys consistent. #3350

Merged
merged 6 commits into from
Jun 28, 2021
Merged

Fix part of #1587: Made some intent/bundle/saved/tags instance keys consistent. #3350

merged 6 commits into from
Jun 28, 2021

Conversation

ayush0402
Copy link
Contributor

@ayush0402 ayush0402 commented Jun 21, 2021 •
edited

Explanation

Made some keys consistent in various Activities and Fragments.
Fixes part of #1587

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@ayush0402
Copy link
Contributor Author

@rt4914 , PTAL

@prayutsu prayutsu self-requested a review June 21, 2021 04:41
prayutsu
prayutsu suggested changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayush0402 Left some comments.
Also please link the issue with this PR

.idea/misc.xml Outdated Show resolved Hide resolved
.idea/runConfigurations.xml Outdated Show resolved Hide resolved
@prayutsu
Copy link
Contributor

@ayush0402 To fix the failing unit tests, identify the failing test file and then try to find the cause of the error. To run the tests locally, read our wiki instructions.

@oppiabot
Copy link

oppiabot bot commented Jun 21, 2021

Hi @ayush0402, it looks like some changes were requested on this pull request by @prayutsu. PTAL. Thanks!

@rt4914 rt4914 removed their assignment Jun 21, 2021
@rt4914
Copy link
Contributor

rt4914 commented Jun 21, 2021

@prayutsu Assign it to me or Akshay once approved from your side.

@prayutsu
Copy link
Contributor

prayutsu commented Jun 23, 2021 •
edited

@ayush0402 You should not resolve conversation threads by yourself, only the person who started the thread should it, it helps in keeping track of the changes they requested. And once you make the changes as requested by the reviewer, you should reply with "Done" or "fixed" so that the reviewer is aware that you have made changes.
Also, if you want any reviewers to take a look, then please drop a PTAL comment and tag the reviewer, so that oppiabot can assign the PRs to them.

@ayush0402
Copy link
Contributor Author

I will keep that in mind for next time. I made the requested changes. @prayutsu PTAL.

prayutsu
prayutsu suggested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayush0402 PTAL. It looks like you missed adding the extra blank line while undoing the changes.
All files must end with an empty new line (also called EOF).
Also please note that the issue hasn't been linked yet. You need to correct the keyword in the PR explanation -- it should be Fixes part of #issueNumber instead of Fix part of #issueNumber.
Thanks!

.idea/misc.xml Outdated Show resolved Hide resolved
.idea/runConfigurations.xml Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jun 23, 2021

Unassigning @ayush0402 since a re-review was requested. @ayush0402, please make sure you have addressed all review comments. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jun 23, 2021

Unassigning @prayutsu since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jun 23, 2021

Hi @ayush0402, it looks like some changes were requested on this pull request by @prayutsu. PTAL. Thanks!

@ayush0402 ayush0402 changed the title Fix part of #1587: Made some intent/bundle/saved/tags instance keys consistent. Fixes part of #1587: Made some intent/bundle/saved/tags instance keys consistent. Jun 23, 2021
@ayush0402
Copy link
Contributor Author

@prayutsu PTAL. Made requested changes.

@oppiabot oppiabot bot assigned prayutsu and unassigned ayush0402 Jun 23, 2021
@oppiabot
Copy link

oppiabot bot commented Jun 23, 2021

Unassigning @ayush0402 since a re-review was requested. @ayush0402, please make sure you have addressed all review comments. Thanks!

prayutsu
prayutsu approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@prayutsu prayutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ayush0402

@prayutsu prayutsu assigned rt4914 and anandwana001 and unassigned prayutsu Jun 25, 2021
@oppiabot
Copy link

oppiabot bot commented Jun 25, 2021

Assigning @fsharpasharp for code owner reviews. Thanks!

@prayutsu
Copy link
Contributor

@ayush0402 I have resolved all the conversations as of now, but you should always reply to the conversation threads with "Done" or "Fixed" when you commit the suggested changes so that the reviewer can resolve the conversation.

fsharpasharp
fsharpasharp approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@fsharpasharp fsharpasharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the changes in IntentFactoryShimImpl.kt

@oppiabot
Copy link

oppiabot bot commented Jun 25, 2021

Unassigning @fsharpasharp since they have already approved the PR.

@anandwana001
Copy link
Contributor

Please follow the first point in the PR checklist and mark it did once done.
Assign me back once Rajat reviews the PR.

@anandwana001 anandwana001 removed their assignment Jun 25, 2021
@ayush0402 ayush0402 changed the title Fixes part of #1587: Made some intent/bundle/saved/tags instance keys consistent. Fix part of #1587: Made some intent/bundle/saved/tags instance keys consistent. Jun 25, 2021
@ayush0402
Copy link
Contributor Author

@anandwana001 Done. PTAL.

rt4914
rt4914 approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayush0402 Nice work. Thanks.

@rt4914 rt4914 removed their assignment Jun 26, 2021
anandwana001
anandwana001 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 merged commit be570f4 into oppia:develop Jun 28, 2021
@ayush0402 ayush0402 deleted the consistent-keys branch June 30, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@fsharpasharp fsharpasharp fsharpasharp approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

@prayutsu prayutsu prayutsu approved these changes

Assignees

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ayush0402 @prayutsu @rt4914 @anandwana001 @fsharpasharp