Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2324: Changes in Submitted Answer List Items [A11y] #3353

Merged
merged 3 commits into from
Jun 21, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 21, 2021

Explanation

Fix #2324

Problem

If learner submits multiple same incorrect answers or atleast 1 incorrect answer in case of DragAndDrop then the A11y Scanner fails because there are multiple same texts.

Solution

For this problem user experience is more important than A11y Scanner failures and therefore for all correct answers we append Correct submitted answer and for all incorrect answers we append Incorrect submitted answer. In this case even if learner enters same incorrect answer multiple types (for which Scanner fails) we are prioritising user experience here.

Have a look at following comments: #2324 (comment) and #2324 (comment)

Output

device-2021-06-21-205721.mp4
device-2021-06-21-212738.mp4
device-2021-06-21-212849.mp4

Screenshot 2021-06-21 at 10 42 41 PM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from anandwana001 June 21, 2021 16:44
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @rt4914

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jun 21, 2021
@oppiabot oppiabot bot added the PR: LGTM label Jun 21, 2021
@rt4914 rt4914 merged commit 17c6a50 into develop Jun 21, 2021
@rt4914 rt4914 deleted the a11y-multiple-submitted-answer branch June 21, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in Submitted Answer List Items [A11y]
2 participants