Fix #3359: Convert welcome.xml into single layout file pull request for issue

[TheSwarnim]

Explanation

Fixes #3359
This PR Convert welcome.xml into a single layout file. In this PR welcome.xml files for different orientations such as land, sw600dp-land and sw600dp-port are deleted and all rendering of the screen is done by the main welcome.xml, and the margin & padding changes dynamically using dimens.xml accordingly.
Please note that to run the project one has to rebuild the project because deleting the orientations welcome.xml files some changes were taking place (Since I don't know this, I struggle for a long time) otherwise it will not work on tablet modes.

Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
• The PR follows the style guide.
• The PR does not contain any unnecessary auto-generated code from Android Studio.
• The PR is made from a branch that's not called "develop".
• The PR is made from a branch that is up-to-date with "develop".
• The PR's branch is based on "develop" and not on any other branch.
• The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

[anandwana001]

Hi @TheSwarnim
Congratulations on your first Pull Request.

Please follow the first two points from the checklist given in the description section.

[TheSwarnim]

Hi @TheSwarnim
Congratulations on your first Pull Request.

Please follow the first two points from the checklist given in the description section.

Thank you, sir, I'll continue to give contributions to this organization, and wants to learn from you in the coming days

[rt4914]

Hi @TheSwarnim
Congratulations on your first Pull Request.
Please follow the first two points from the checklist given in the description section.

Thank you, sir, I'll continue to give contributions to this organization, and wants to learn from you in the coming days

@TheSwarnim As per the issue description, please add Before/After screenshots of the HomeScreen in mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape so that we can easily compare if changes are done correctly or not.

Also in practice whenever there is a UI change we always add screenshots to PRs and when there are test cases changes then we add screenshot of tests passing.

[TheSwarnim]

Hi @TheSwarnim
Congratulations on your first Pull Request.
Please follow the first two points from the checklist given in the description section.

Thank you, sir, I'll continue to give contributions to this organization, and wants to learn from you in the coming days

@TheSwarnim As per the issue description, please add Before/After screenshots of the HomeScreen in mobile-portrait, mobile-landscape, tablet-portrait and tablet-landscape so that we can easily compare if changes are done correctly or not.

Also in practice whenever there is a UI change we always add screenshots to PRs and when there are test cases changes then we add screenshot of tests passing.

Ok sir,

Before

mobile-portrait

mobile-land

tablet-port

tablet-land

After

mobile-land

mobile-port

tablet-land

tablet-port

[rt4914]

@TheSwarnim Thanks. I have left one suggestion which applies to all files.

[rt4914]

Do not use already defined values for this as it created dependencies on one another.

Create new dimens values like home_welcome_outer_padding

[TheSwarnim]

Ok sir I'll see it and use different dimens.

[TheSwarnim]

Hello @rt4914, Sir, I've created the dimens values as per the requirement. Please review it

[rt4914]

Suggested changes for files which should not be changed. Otherwise everything looks good.

[TheSwarnim]

Hello @rt4914, Sir, please review it again, the error has occurred because I've not added these above files in commit mistakingly.

[rt4914]

Hello @rt4914, Sir, please review it again, the error has occurred because I've not added these above files in commit mistakingly.

@TheSwarnim Thanks. Also make sure that you reply to all open comments so that the reviewer can understand what was the step taken on that particular comment.

[rt4914]

LGTM, thanks.

[oppiabot]

Unassigning @rt4914 since they have already approved the PR.

[rt4914]

@TheSwarnim Please update your branch by merging with latest develop so that we can merge this PR