Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2323: Drag and drop a11y fix #3388

Merged
merged 8 commits into from
Jun 29, 2021
Merged

Fix #2323: Drag and drop a11y fix #3388

merged 8 commits into from
Jun 29, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 29, 2021

Explanation

Fix #2323: Drag and drop a11y fix

Output

a11y_drag_and_drop_correct.mp4

Espresso Tests

Screenshot 2021-06-29 at 3 09 24 PM

Screenshot 2021-06-29 at 11 30 49 PM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from anandwana001 June 29, 2021 08:52
@rt4914 rt4914 changed the base branch from develop to highfi-drag-and-drop June 29, 2021 10:16
Base automatically changed from highfi-drag-and-drop to develop June 29, 2021 16:42
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented Jun 29, 2021

Unassigning @anandwana001 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jun 29, 2021
@rt4914 rt4914 assigned rt4914 and anandwana001 and unassigned rt4914 Jun 29, 2021
@rt4914 rt4914 merged commit ba151c5 into develop Jun 29, 2021
@rt4914 rt4914 deleted the drag-and-drop-a11y-fix branch June 29, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in Drag Drop Interactions Item [A11y] [BLOCKED]
2 participants