Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1643: Highfi image region selection #3391

Merged
merged 9 commits into from
Jul 1, 2021
Merged

Fix #1643: Highfi image region selection #3391

merged 9 commits into from
Jul 1, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 29, 2021 •
edited

Explanation

Fix #1643: Highfi image region selection

https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/792fefa6-47fc-4e07-bc6b-d4e60065a593/specs/

We are making sure that all external margins are the common margins that we are using everywhere else.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the base branch from develop to highfi-drag-and-drop June 29, 2021 16:00
Base automatically changed from highfi-drag-and-drop to develop June 29, 2021 16:42
@rt4914 rt4914 requested a review from anandwana001 June 30, 2021 03:50
anandwana001
anandwana001 approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented Jun 30, 2021

Unassigning @anandwana001 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jun 30, 2021
@rt4914 rt4914 self-assigned this Jun 30, 2021
@rt4914 rt4914 merged commit fe553d3 into develop Jul 1, 2021
@rt4914 rt4914 deleted the highfi-image-region-selection branch July 1, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@rt4914 rt4914

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full highfi work for ImageRegionSelection
3 participants
@rt4914 @anandwana001 @aggarwalpulkit596